added negative tests

Author: sfc-gh-sshetkar

test/csp_helpers.py

@@ -394,8 +394,6 @@ class FakeAwsEnvironment:
     called by the connector code.
     """
 
-    LAMBDA_TASK_ROOT_ENVIRONMENT_VARIABLE_NAME = "LAMBDA_TASK_ROOT"
-
     def __init__(self):
         # Defaults used for generating a token. Can be overriden in individual tests.
         self.arn = "arn:aws:sts::123456789:assumed-role/My-Role/i-34afe100cad287fab"
@@ -437,9 +435,7 @@ def boto3_client(self, *args, **kwargs):
         return mock_client
 
     def __enter__(self):
-        os.environ[self.LAMBDA_TASK_ROOT_ENVIRONMENT_VARIABLE_NAME] = (
-            self.lambda_task_root
-        )
+        os.environ["LAMBDA_TASK_ROOT"] = self.lambda_task_root
 
         # Patch the relevant functions to do what we want.
         self.patchers = []
@@ -488,6 +484,6 @@ def __enter__(self):
         return self
 
     def __exit__(self, *args, **kwargs):
-        os.environ.pop(self.LAMBDA_TASK_ROOT_ENVIRONMENT_VARIABLE_NAME)
+        os.environ.pop("LAMBDA_TASK_ROOT")
         for patcher in self.patchers:
             patcher.__exit__(*args, **kwargs)

test/unit/test_detect_platforms.py

@@ -152,3 +152,35 @@ def test_missing_arn_handling(self, broken_metadata_service, fake_aws_environmen
         fake_aws_environment.caller_identity = {"UserId": "test-user"}
         result = detect_platforms(timeout_seconds=None)
         assert "has_aws_identity" not in result
+
+    def test_azure_managed_identity_wrong_issuer(self, fake_azure_vm_metadata_service):
+        fake_azure_vm_metadata_service.iss = "https://fake-issuer.com"
+        result = detect_platforms(timeout_seconds=None)
+        assert "azure_managed_identity" not in result
+
+    def test_azure_function_missing_identity_endpoint(self, broken_metadata_service):
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_azure_function" not in result
+
+    def test_aws_ec2_empty_instance_document(
+        self, broken_metadata_service, fake_aws_environment
+    ):
+        fake_aws_environment.instance_document = b""
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_ec2_instance" not in result
+
+    def test_aws_lambda_empty_task_root(self, broken_metadata_service):
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_aws_lambda" not in result
+
+    def test_github_actions_missing_environment_variable(self, broken_metadata_service):
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_github_action" not in result
+
+    def test_gce_cloud_run_service_missing_k_service(self, broken_metadata_service):
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_gce_cloud_run_service" not in result
+
+    def test_gce_cloud_run_job_missing_cloud_run_job(self, broken_metadata_service):
+        result = detect_platforms(timeout_seconds=None)
+        assert "is_gce_cloud_run_job" not in result