Update according to comments

Author: sfc-gh-pbulawa

src/snowflake/connector/connection.py

@@ -488,6 +488,11 @@ def __init__(
         # check SNOW-1218851 for long term improvement plan to refactor ocsp code
         atexit.register(self._close_at_exit)
 
+    # Deprecated
+    @property
+    def insecure_mode(self) -> bool:
+        return self._disable_ocsp_checks
+
     @property
     def disable_ocsp_checks(self) -> bool:
         return self._disable_ocsp_checks
@@ -497,8 +502,7 @@ def ocsp_fail_open(self) -> bool:
         return self._ocsp_fail_open
 
     def _ocsp_mode(self) -> OCSPMode:
-        """OCSP mode. INSEC
-        URE, FAIL_OPEN or FAIL_CLOSED."""
+        """OCSP mode. DISABLE_OCSP_CHECKS, FAIL_OPEN or FAIL_CLOSED."""
         if self.disable_ocsp_checks:
             return OCSPMode.DISABLE_OCSP_CHECKS
         elif self.ocsp_fail_open:

src/snowflake/connector/constants.py

@@ -354,11 +354,13 @@ class OCSPMode(Enum):
         FAIL_OPEN: A response indicating a revoked certificate results in a failed connection. A response with any
             other certificate errors or statuses allows the connection to occur, but denotes the message in the logs
             at the WARNING level with the relevant details in JSON format.
+        INSECURE (deprecated): The connection will occur anyway.
         DISABLE_OCSP_CHECKS: The OCSP check will not happen. If the certificate is valid then connection will occur.
     """
 
     FAIL_CLOSED = "FAIL_CLOSED"
     FAIL_OPEN = "FAIL_OPEN"
+    INSECURE = "INSECURE"
     DISABLE_OCSP_CHECKS = "DISABLE_OCSP_CHECKS"
 
 

src/snowflake/connector/ocsp_snowflake.py

@@ -396,7 +396,7 @@ def generate_telemetry_data(
                 TelemetryField.KEY_OOB_OCSP_REQUEST_BASE64.value: self.ocsp_req,
                 TelemetryField.KEY_OOB_OCSP_RESPONDER_URL.value: self.ocsp_url,
                 TelemetryField.KEY_OOB_ERROR_MESSAGE.value: self.error_msg,
-                TelemetryField.KEY_OOB_DISABLE_OCSP_CHECKS.value: self.disable_ocsp_checks,
+                TelemetryField.KEY_OOB_INSECURE_MODE.value: self.disable_ocsp_checks,
                 TelemetryField.KEY_OOB_FAIL_OPEN.value: self.fail_open,
                 TelemetryField.KEY_OOB_CACHE_ENABLED.value: self.cache_enabled,
                 TelemetryField.KEY_OOB_CACHE_HIT.value: self.cache_hit,

src/snowflake/connector/telemetry.py

@@ -79,7 +79,7 @@ class TelemetryField(Enum):
     KEY_OOB_CERT_ID = "certId"
     KEY_OOB_OCSP_REQUEST_BASE64 = "ocspRequestBase64"
     KEY_OOB_OCSP_RESPONDER_URL = "ocspResponderURL"
-    KEY_OOB_DISABLE_OCSP_CHECKS = "disableOcspChecks"
+    KEY_OOB_INSECURE_MODE = "insecureMode"
     KEY_OOB_FAIL_OPEN = "failOpen"
     KEY_OOB_CACHE_ENABLED = "cacheEnabled"
     KEY_OOB_CACHE_HIT = "cacheHit"