fix mem leak in logging and add notes in source code

sfc-gh-aling · sfc-gh-aling · commit 5c9aed2ca966 · 2023-08-01T00:06:02.000-07:00
diff --git a/src/snowflake/connector/cpp/ArrowIterator/CArrowChunkIterator.cpp b/src/snowflake/connector/cpp/ArrowIterator/CArrowChunkIterator.cpp
@@ -98,6 +98,7 @@ CArrowChunkIterator::CArrowChunkIterator(PyObject* context, std::vector<std::sha
 
 CArrowChunkIterator::~CArrowChunkIterator()
 {
+    // TODO: signal 6: SIGABRT free already deallocated memory
     for(int i = 0; i < m_arrays.size(); i += 1) {
         m_arrays[i]->release(m_arrays[i].get());
         ArrowArrayViewReset(m_arrayViews[i].get());

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ CArrowChunkIterator::CArrowChunkIterator(PyObject* context, std::vector<std::sha`
`98`	`98`
`99`	`99`	`CArrowChunkIterator::~CArrowChunkIterator()`
`100`	`100`	`{`
	`101`	`+ // TODO: signal 6: SIGABRT free already deallocated memory`
`101`	`102`	`for(int i = 0; i < m_arrays.size(); i += 1) {`
`102`	`103`	`m_arrays[i]->release(m_arrays[i].get());`
`103`	`104`	`ArrowArrayViewReset(m_arrayViews[i].get());`