Snow-2043523: windows support for Python 3.13 (#2275)

(cherry picked from commit ba6e0f5)

Author: sfc-gh-fpawlowski

.github/workflows/build_test.yml

@@ -129,15 +129,7 @@ jobs:
            download_name: win_amd64
         python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         cloud-provider: [aws, azure, gcp]
-        # TODO: When there are prebuilt wheels accessible for our dependencies (i.e. numpy)
-        # for Python 3.13 windows runs can be re-enabled. Currently, according to numpy:
-        # "Numpy built with MINGW-W64 on Windows 64 bits is experimental, and only available for
-        # testing. You are advised not to use it for production."
-        exclude:
-          - os:
-              image_name: windows-latest
-              download_name: win_amd64
-            python-version: "3.13"
+
     steps:
       - uses: actions/checkout@v4
       - name: Set up Python
@@ -175,12 +167,17 @@ jobs:
       - name: Install tox
         run: python -m pip install tox>=4
       - name: Run tests
+       # To run a single test on GHA use the below command:
+       # run: python -m tox run -e `echo py${PYTHON_VERSION/\./}-single-ci | sed 's/ /,/g'`
         run: python -m tox run -e `echo py${PYTHON_VERSION/\./}-{extras,unit,integ,pandas,sso}-ci | sed 's/ /,/g'`
+
         env:
           PYTHON_VERSION: ${{ matrix.python-version }}
           cloud_provider: ${{ matrix.cloud-provider }}
           PYTEST_ADDOPTS: --color=yes --tb=short
           TOX_PARALLEL_NO_SPINNER: 1
+         # To specify the test name (in single test mode) pass this env variable:
+         # SINGLE_TEST_NAME: test/file/path::test_name
         shell: bash
       - name: Combine coverages
         run: python -m tox run -e coverage --skip-missing-interpreters false

ci/docker/connector_test/Dockerfile

@@ -3,8 +3,7 @@ FROM $BASE_IMAGE
 
 RUN yum install -y java-11-openjdk
 
-# TODO: When there are prebuilt wheels accessible for our dependencies (i.e. numpy)
-# for Python 3.13 this rust cargo install command can be removed.
+# Our dependencies rely on the Rust toolchain being available in the build-time environment (https://github.com/pyca/cryptography/issues/5771)
 RUN yum -y install rust cargo
 
 # This is to solve permission issue, read https://denibertovic.com/posts/handling-permissions-with-docker-volumes/

ci/docker/connector_test_lambda/Dockerfile313

@@ -2,24 +2,13 @@ FROM public.ecr.aws/lambda/python:3.13-x86_64
 
 WORKDIR /home/user/snowflake-connector-python
 
-# TODO: When there are prebuilt wheels accessible for our dependencies (i.e. numpy)
-# for Python 3.13 all dnf ... commands installing building kits can be removed.
-
-# Install necessary packages and compilers - we need to build numpy for newer version
-# Update dnf and install development tools
 RUN dnf -y update && \
-    dnf -y install \
-    gcc \
-    gcc-c++ \
-    make \
-    python3-devel \
-    openblas-devel \
-    lapack-devel && \
     dnf clean all
+
+# Our dependencies rely on the Rust toolchain being available in the build-time environment (https://github.com/pyca/cryptography/issues/5771)
 RUN dnf -y install rust cargo
 RUN dnf -y upgrade
 
-
 RUN chmod 777 /home/user/snowflake-connector-python
 ENV PATH="${PATH}:/opt/python/cp313-cp313/bin/"
 ENV PYTHONPATH="${PYTHONPATH}:/home/user/snowflake-connector-python/ci/docker/connector_test_lambda/"

setup.cfg

@@ -81,7 +81,7 @@ development =
     Cython
     coverage
     more-itertools
-    numpy<2.1.0
+    numpy<=2.2.4
     pendulum!=2.1.1
     pexpect
     pytest<7.5.0

src/snowflake/connector/file_transfer_agent.py

@@ -20,7 +20,7 @@
 from typing import IO, TYPE_CHECKING, Any, Callable, TypeVar
 
 from .azure_storage_client import SnowflakeAzureRestClient
-from .compat import GET_CWD, IS_WINDOWS
+from .compat import IS_WINDOWS
 from .constants import (
     AZURE_CHUNK_SIZE,
     AZURE_FS,
@@ -826,17 +826,17 @@ def _expand_filenames(self, locations: list[str]) -> list[str]:
         for file_name in locations:
             if self._command_type == CMD_TYPE_UPLOAD:
                 file_name = os.path.expanduser(file_name)
-                if not os.path.isabs(file_name):
-                    file_name = os.path.join(GET_CWD(), file_name)
                 if (
                     IS_WINDOWS
                     and len(file_name) > 2
                     and file_name[0] == "/"
                     and file_name[2] == ":"
                 ):
-                    # Windows path: /C:/data/file1.txt where it starts with slash
-                    # followed by a drive letter and colon.
+                    # Since python 3.13 os.path.isabs returns different values for URI or paths starting with a '/' etc. on Windows (https://github.com/python/cpython/issues/125283)
+                    # Windows path: /C:/data/file1.txt is not treated as absolute - could be prefixed with another Windows driver's letter and colon.
                     file_name = file_name[1:]
+                if not os.path.isabs(file_name):
+                    file_name = os.path.abspath(file_name)
                 files = glob.glob(file_name)
                 canonical_locations += files
             else:

tox.ini

@@ -18,7 +18,7 @@ source = src/snowflake/connector
 [tox]
 minversion = 4
 envlist = fix_lint,
-          py{39,310,311,312,313}-{extras,unit-parallel,integ,pandas,sso},
+          py{39,310,311,312,313}-{extras,unit-parallel,integ,pandas,sso,single},
           coverage
 skip_missing_interpreters = true
 
@@ -36,8 +36,10 @@ setenv =
     # aio is only supported on python >= 3.10
     unit-integ: SNOWFLAKE_TEST_TYPE = (unit or integ)
     !unit-!integ: SNOWFLAKE_TEST_TYPE = (unit or integ)
+    auth: SNOWFLAKE_TEST_TYPE = auth and not aio
     unit: SNOWFLAKE_TEST_TYPE = unit and not aio
     integ: SNOWFLAKE_TEST_TYPE = integ and not aio
+    single: SNOWFLAKE_TEST_TYPE = single
     parallel: SNOWFLAKE_PYTEST_OPTS = {env:SNOWFLAKE_PYTEST_OPTS:} -n auto
     # Add common parts into pytest command
     SNOWFLAKE_PYTEST_COV_LOCATION = {env:JUNIT_REPORT_DIR:{toxworkdir}}/junit.{envname}-{env:cloud_provider:dev}.xml
@@ -54,6 +56,7 @@ passenv =
     # Github Actions provided environmental variables
     GITHUB_ACTIONS
     JENKINS_HOME
+    SINGLE_TEST_NAME
     # This is required on windows. Otherwise pwd module won't be imported successfully,
     # see https://github.com/tox-dev/tox/issues/1455
     USERNAME
@@ -62,11 +65,12 @@ passenv =
 commands =
     # Test environments
     # Note: make sure to have a default env and all the other special ones
-    !pandas-!sso-!lambda-!extras: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and not sso and not pandas and not lambda and not aio" {posargs:} test
+    !pandas-!sso-!lambda-!extras-!single: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and not sso and not pandas and not lambda and not aio" {posargs:} test
     pandas: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and pandas and not aio" {posargs:} test
     sso: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and sso and not aio" {posargs:} test
     lambda: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and lambda and not aio" {posargs:} test
     extras: python -m test.extras.run {posargs:}
+    single: {env:SNOWFLAKE_PYTEST_CMD} -s "{env:SINGLE_TEST_NAME}" {posargs:}
 
 [testenv:olddriver]
 basepython = python3.9
@@ -90,7 +94,9 @@ skip_install = True
 setenv = {[testenv]setenv}
 passenv = {[testenv]passenv}
 commands =
-    {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "not skipolddriver" -vvv {posargs:} test
+    # Unit and pandas tests are already skipped for the old driver (see test/conftest.py). Avoid walking those
+    # directories entirely to avoid loading any potentially incompatible subdirectories' own conftest.py files.
+    {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} --ignore=test/unit --ignore=test/pandas -m "not skipolddriver" -vvv {posargs:} test
 
 [testenv:noarrowextension]
 basepython = python3.9
@@ -188,6 +194,7 @@ markers =
     # Test type markers
     integ: integration tests
     unit: unit tests
+    auth: tests for authentication
     skipolddriver: skip for old driver tests
     # Other markers
     timeout: tests that need a timeout time