Skip to content

Commit 89a54fc

Browse files
SNOW-680774 Check CLIENT_LOG_DIR_PATH_DOCKER for ENABLE_TELEMETRY_LOG (#1288)
* SNOW-680774 Check CLIENT_LOG_DIR_PATH_DOCKER for ENABLE_TELEMETRY_LOG Description test_util is supposed to only be used by snowflake regression test, but currently it runs for all Jenkins linux hosts, which is not desired. A quick fix is to also check CLIENT_LOG_DIR_PATH_DOCKER, which presumbly is not used by most customers if not all. Testing existing tests * fix fix_lint * address comment Co-authored-by: Mark Keller <[email protected]>
1 parent 32b459e commit 89a54fc

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ repos:
6161
hooks:
6262
- id: pyupgrade
6363
args: [--py37-plus]
64-
- repo: https://gitlab.com/pycqa/flake8
65-
rev: 3.9.2
64+
- repo: https://github.com/PyCQA/flake8
65+
rev: 5.0.4
6666
hooks:
6767
- id: flake8
6868
additional_dependencies:
69-
- flake8-bugbear == 20.11.1
69+
- flake8-bugbear
7070
- repo: https://github.com/psf/black
7171
rev: 22.3.0
7272
hooks:

src/snowflake/connector/test_util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
from .compat import IS_LINUX
1212

1313
RUNNING_ON_JENKINS = os.getenv("JENKINS_HOME") is not None
14-
REGRESSION_TEST_LOG_DIR = os.getenv("CLIENT_LOG_DIR_PATH_DOCKER", "/tmp")
15-
ENABLE_TELEMETRY_LOG = RUNNING_ON_JENKINS and IS_LINUX
14+
REGRESSION_TEST_LOG_DIR = os.getenv("CLIENT_LOG_DIR_PATH_DOCKER")
15+
ENABLE_TELEMETRY_LOG = RUNNING_ON_JENKINS and REGRESSION_TEST_LOG_DIR and IS_LINUX
1616
rt_plain_logger = None
1717

1818

0 commit comments

Comments
 (0)