SNOW-83042: Switched on raise_put_get_error on Python connector by default

Author: sfc-gh-stakeda

cursor.py

@@ -456,7 +456,7 @@ def execute(self, command, params=None, timeout=None,
                 _no_results=False,
                 _use_ijson=False,
                 _is_put_get=None,
-                _raise_put_get_error=False,
+                _raise_put_get_error=True,
                 _force_put_overwrite=False):
         u"""
         Executes a command/query
@@ -497,11 +497,7 @@ def execute(self, command, params=None, timeout=None,
                 processed_params = self._connection._process_params_qmarks(
                     params, self)
         # Skip reporting Key, Value and Type errors
-        except KeyError:
-            raise
-        except ValueError:
-            raise
-        except TypeError:
+        except (KeyError, ValueError, TypeError):
             raise
         except Exception:
             self.connection.incident.report_incident()

file_transfer_agent.py

@@ -185,7 +185,7 @@ def __init__(self, cursor, command, ret,
                  get_azure_callback=None,
                  get_callback_output_stream=sys.stdout,
                  show_progress_bar=True,
-                 raise_put_get_error=False,
+                 raise_put_get_error=True,
                  force_put_overwrite=True):
         self._cursor = cursor
         self._command = command

test/test_put_get_medium.py

@@ -451,7 +451,7 @@ def run(cnx, sql):
         sql = sql.format(
             files=files.replace('\\', '\\\\'),
             name=db_parameters['name'])
-        return cnx.cursor().execute(sql).fetchall()
+        return cnx.cursor().execute(sql, _raise_put_get_error=False).fetchall()
 
     with conn_cnx(
             user=db_parameters['s3_user'],

test/test_put_get_user_stage.py

@@ -239,8 +239,8 @@ def test_put_get_duplicated_data_user_stage(is_public_test, tmpdir, test_files,
             c = cnx.cursor()
             try:
                 for rec in c.execute(
-                        "put file://{file} @{stage_name}".format(
-                            file=files, stage_name=stage_name)):
+                        "put file://{file} @{stage_name}".format(file=files, stage_name=stage_name),
+                        _raise_put_get_error=False):
                     logger.info('rec=%s', rec)
                     if rec[6] == 'UPLOADED':
                         success_cnt += 1

test/test_put_get_with_azure_token.py

@@ -167,7 +167,7 @@ def run(cnx, sql):
         sql = sql.format(
             files=files,
             name=db_parameters['name'])
-        return cnx.cursor().execute(sql).fetchall()
+        return cnx.cursor().execute(sql, _raise_put_get_error=False).fetchall()
 
     with conn_cnx(
             user=db_parameters['azure_user'],

test/test_unit_put_get.py

@@ -19,7 +19,7 @@
 @pytest.mark.skipif(IS_WINDOWS, reason='permission model is different')
 def test_put_error(tmpdir):
     """
-    Test for raise_put_get_error flag in SnowflakeFileTransferAgent
+    Test for raise_put_get_error flag (now turned on by default) in SnowflakeFileTransferAgent
     """
     tmp_dir = str(tmpdir.mkdir('putfiledir'))
     file1 = path.join(tmp_dir, 'file1')
@@ -68,4 +68,13 @@ def test_put_error(tmpdir):
     with pytest.raises(Exception):
         sf_file_transfer_agent.result()
 
+    # unspecified, should fail because flag is on by default now
+    sf_file_transfer_agent = SnowflakeFileTransferAgent(
+        cursor,
+        query,
+        ret)
+    sf_file_transfer_agent.execute()
+    with pytest.raises(Exception):
+        sf_file_transfer_agent.result()
+
     chmod(file1, 0o700)