fixup! fixup! fixup! fixup! Run only test_external_browser_successful

Author: sfc-gh-turbaszek

test/auth/aio/authorization_test_helper.py

@@ -76,54 +76,54 @@ async def connect_and_provide_credentials(
     ):
         import asyncio
 
-        # try:
-        # Start connection as an async task in the main event loop
-        # This allows the browser to be opened from the main thread context
-        connect_task = asyncio.create_task(self.connect_and_execute_simple_query())
-
-        if self.auth_test_env == "docker":
-            # Give connection time to start and open the browser
-            await asyncio.sleep(5)
-
-            # Run browser automation in a thread WITHOUT blocking the event loop
-            # This allows the connection task to continue making progress
-            loop = asyncio.get_running_loop()
-            credentials_task = loop.run_in_executor(
-                None,
-                self._provide_credentials,
-                scenario,
-                login,
-                password,
-            )
+        try:
+            # Start connection as an async task in the main event loop
+            # This allows the browser to be opened from the main thread context
+            connect_task = asyncio.create_task(self.connect_and_execute_simple_query())
+
+            if self.auth_test_env == "docker":
+                # Give connection time to start and open the browser
+                await asyncio.sleep(5)
+
+                # Run browser automation in a thread WITHOUT blocking the event loop
+                # This allows the connection task to continue making progress
+                loop = asyncio.get_running_loop()
+                credentials_task = loop.run_in_executor(
+                    None,
+                    self._provide_credentials,
+                    scenario,
+                    login,
+                    password,
+                )
 
-            # Wait for both tasks to complete concurrently
-            await asyncio.gather(connect_task, credentials_task)
-        else:
-            # Wait for connection to complete
-            await connect_task
+                # Wait for both tasks to complete concurrently
+                await asyncio.gather(connect_task, credentials_task)
+            else:
+                # Wait for connection to complete
+                await connect_task
 
-        # except Exception as e:
-        #     self.error_msg = e
-        #     logger.error(e)
+        except Exception as e:
+            self.error_msg = e
+            logger.error(e)
 
     def get_error_msg(self) -> str:
         return str(self.error_msg)
 
     async def connect_and_execute_simple_query(self):
-        # try:
-        logger.info("Trying to connect to Snowflake")
-        async with snowflake.connector.aio.SnowflakeConnection(
-            **self.configuration
-        ) as con:
-            logger.info("Connected to Snowflake, executing query")
-            result = await con.cursor().execute("select 1;")
-            logger.debug(await result.fetchall())
-            logger.info("Successfully connected to Snowflake")
-            return True
-        # except Exception as e:
-        #     self.error_msg = e
-        #     logger.error(e)
-        #     return False
+        try:
+            logger.info("Trying to connect to Snowflake")
+            async with snowflake.connector.aio.SnowflakeConnection(
+                **self.configuration
+            ) as con:
+                logger.info("Connected to Snowflake, executing query")
+                result = await con.cursor().execute("select 1;")
+                logger.debug(await result.fetchall())
+                logger.info("Successfully connected to Snowflake")
+                return True
+        except Exception as e:
+            self.error_msg = e
+            logger.error(e)
+            return False
 
     async def connect_and_execute_set_session_state(self, key: str, value: str):
         try:
@@ -172,7 +172,7 @@ def _provide_credentials(self, scenario: Scenario, login: str, password: str):
                 ],
                 timeout=30,
             )
-            # logger.debug(f"OUTPUT:  {process.stdout}, ERRORS: {process.stderr}")
+            logger.debug(f"OUTPUT:  {process.stdout}, ERRORS: {process.stderr}")
         except Exception as e:
             self.error_msg = e
             raise RuntimeError(e)

test/auth/aio/test_external_browser.py

@@ -25,13 +25,15 @@ def setup_and_teardown():
 
 @pytest.mark.auth
 @pytest.mark.asyncio
+# @pytest.mark.skip(reason="SNOW-2895170: Script providing credentials cannot connect to browser")
 async def test_external_browser_successful():
     logging.getLogger("snowflake.connector").setLevel(logging.DEBUG)
     connection_parameters = (
         AuthConnectionParameters().get_external_browser_connection_parameters()
     )
-    test_helper = AuthorizationTestHelper(connection_parameters)
     browser_login, browser_password = get_okta_login_credentials().values()
+
+    test_helper = AuthorizationTestHelper(connection_parameters)
     await test_helper.connect_and_provide_credentials(
         Scenario.SUCCESS, browser_login, browser_password
     )