SNOW-1740361: raise error below python less than 3 10 (#2075)

Author: sfc-gh-aling

.github/workflows/build_test.yml

@@ -395,6 +395,36 @@ jobs:
             .tox/.coverage
             .tox/coverage.xml
 
+  test-unsupporeted-aio:
+    name: Test unsupported asyncio ${{ matrix.os.download_name }}-${{ matrix.python-version }}
+    runs-on: ${{ matrix.os.image_name }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - image_name: ubuntu-latest
+            download_name: manylinux_x86_64
+        python-version: [ "3.8", "3.9" ]
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Display Python version
+        run: python -c "import sys; print(sys.version)"
+      - name: Upgrade setuptools, pip and wheel
+        run: python -m pip install -U setuptools pip wheel
+      - name: Install tox
+        run: python -m pip install tox>=4
+      - name: Run tests
+        run: python -m tox run -e aio-unsupported-python
+        env:
+          PYTHON_VERSION: ${{ matrix.python-version }}
+          PYTEST_ADDOPTS: --color=yes --tb=short
+          TOX_PARALLEL_NO_SPINNER: 1
+        shell: bash
+
   combine-coverage:
     if: ${{ success() || failure() }}
     name: Combine coverage

setup.cfg

@@ -92,7 +92,6 @@ development =
     pytest-xdist
     pytzdata
     pytest-asyncio
-    aiohttp
 pandas =
     pandas>=1.0.0,<3.0.0
     pyarrow

src/snowflake/connector/aio/_result_set.py

@@ -18,6 +18,7 @@
     Deque,
     Iterator,
     Literal,
+    Union,
     cast,
     overload,
 )
@@ -156,7 +157,7 @@ def __init__(
     ) -> None:
         super().__init__(cursor, result_chunks, prefetch_thread_num)
         self.batches = cast(
-            list[JSONResultBatch] | list[ArrowResultBatch], self.batches
+            Union[list[JSONResultBatch], list[ArrowResultBatch]], self.batches
         )
 
     def _can_create_arrow_iter(self) -> None:

src/snowflake/connector/aio/_ssl_connector.py

@@ -5,6 +5,7 @@
 from __future__ import annotations
 
 import logging
+import sys
 from typing import TYPE_CHECKING
 
 import aiohttp
@@ -27,15 +28,19 @@
 
 class SnowflakeSSLConnector(aiohttp.TCPConnector):
     def __init__(self, *args, **kwargs):
-        import sys
-
-        if sys.version_info <= (3, 9):
-            raise RuntimeError(
-                "The asyncio support for Snowflake Python Connector is only supported on Python 3.10 or greater."
-            )
         self._snowflake_ocsp_mode = kwargs.pop(
             "snowflake_ocsp_mode", OCSPMode.FAIL_OPEN
         )
+        if self._snowflake_ocsp_mode == OCSPMode.FAIL_OPEN and sys.version_info < (
+            3,
+            10,
+        ):
+            raise RuntimeError(
+                "Async Snowflake Python Connector requires Python 3.10+ for OCSP validation related features. "
+                "Please open a feature request issue in github if your want to use Python 3.9 or lower: "
+                "https://github.com/snowflakedb/snowflake-connector-python/issues/new/choose."
+            )
+
         super().__init__(*args, **kwargs)
 
     async def connect(

test/aiodep/unsupported_python_version.py

@@ -0,0 +1,41 @@
+#
+# Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.
+#
+
+import asyncio
+import sys
+
+import snowflake.connector.aio
+
+assert (
+    sys.version_info.major == 3 and sys.version_info.minor <= 9
+), "This test is only for Python 3.9 and lower"
+
+
+CONNECTION_PARAMETERS = {
+    "account": "test",
+    "user": "test",
+    "password": "test",
+    "schema": "test",
+    "database": "test",
+    "protocol": "test",
+    "host": "test.snowflakecomputing.com",
+    "warehouse": "test",
+    "port": 443,
+    "role": "test",
+}
+
+
+async def main():
+    try:
+        async with snowflake.connector.aio.SnowflakeConnection(**CONNECTION_PARAMETERS):
+            pass
+    except Exception as exc:
+        assert isinstance(
+            exc, RuntimeError
+        ) and "Async Snowflake Python Connector requires Python 3.10+" in str(
+            exc
+        ), "should raise RuntimeError"
+
+
+asyncio.run(main())

tox.ini

@@ -43,6 +43,7 @@ setenv =
     SNOWFLAKE_PYTEST_COV_LOCATION = {env:JUNIT_REPORT_DIR:{toxworkdir}}/junit.{envname}-{env:cloud_provider:dev}.xml
     SNOWFLAKE_PYTEST_COV_CMD = --cov snowflake.connector --junitxml {env:SNOWFLAKE_PYTEST_COV_LOCATION} --cov-report=
     SNOWFLAKE_PYTEST_CMD = pytest {env:SNOWFLAKE_PYTEST_OPTS:} {env:SNOWFLAKE_PYTEST_COV_CMD}
+    SNOWFLAKE_PYTEST_CMD_IGNORE_AIO = {env:SNOWFLAKE_PYTEST_CMD} --ignore=test/integ/aio --ignore=test/unit/aio
     SNOWFLAKE_TEST_MODE = true
 passenv =
     AWS_ACCESS_KEY_ID
@@ -61,10 +62,10 @@ passenv =
 commands =
     # Test environments
     # Note: make sure to have a default env and all the other special ones
-    !pandas-!sso-!lambda-!extras: {env:SNOWFLAKE_PYTEST_CMD} -m "{env:SNOWFLAKE_TEST_TYPE} and not sso and not pandas and not lambda and not aio" {posargs:} test
-    pandas: {env:SNOWFLAKE_PYTEST_CMD} -m "{env:SNOWFLAKE_TEST_TYPE} and pandas and not aio" {posargs:} test
-    sso: {env:SNOWFLAKE_PYTEST_CMD} -m "{env:SNOWFLAKE_TEST_TYPE} and sso and not aio" {posargs:} test
-    lambda: {env:SNOWFLAKE_PYTEST_CMD} -m "{env:SNOWFLAKE_TEST_TYPE} and lambda and not aio" {posargs:} test
+    !pandas-!sso-!lambda-!extras: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and not sso and not pandas and not lambda and not aio" {posargs:} test
+    pandas: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and pandas and not aio" {posargs:} test
+    sso: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and sso and not aio" {posargs:} test
+    lambda: {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "{env:SNOWFLAKE_TEST_TYPE} and lambda and not aio" {posargs:} test
     extras: python -m test.extras.run {posargs:}
 
 [testenv:olddriver]
@@ -87,7 +88,7 @@ skip_install = True
 setenv = {[testenv]setenv}
 passenv = {[testenv]passenv}
 commands =
-    {env:SNOWFLAKE_PYTEST_CMD} -m "not skipolddriver" -vvv {posargs:} test --ignore=test/integ/aio --ignore=test/unit/aio
+    {env:SNOWFLAKE_PYTEST_CMD_IGNORE_AIO} -m "not skipolddriver" -vvv {posargs:} test
 
 [testenv:noarrowextension]
 basepython = python3.8
@@ -106,6 +107,14 @@ extras=
     pandas
 commands = {env:SNOWFLAKE_PYTEST_CMD} -m "aio" -vvv {posargs:} test
 
+[testenv:aio-unsupported-python]
+description = Run aio connector on unsupported python versions
+extras=
+    aio
+commands =
+    pip install .
+    python test/aiodep/unsupported_python_version.py
+
 [testenv:coverage]
 description = [run locally after tests]: combine coverage data and create report
 ;              generates a diff coverage against origin/master (can be changed by setting DIFF_AGAINST env var)