SNOW-1208964: Fix source file path resolution for local storage client (#1896)

* SNOW-1208964: Fix source file path resolution for local storage client

Co-authored-by: Yuyang Wang <[email protected]>

Author: sfc-gh-psanford

src/snowflake/connector/local_storage_client.py

@@ -33,9 +33,14 @@ def __init__(
             stage_info["location"], os.path.basename(meta.dst_file_name)
         )
         if meta.local_location:
-            self.stage_file_name = self.full_dst_file_name
+            src_file_name = self.data_file
+            if src_file_name.startswith("/"):
+                src_file_name = src_file_name[1:]
+            self.stage_file_name: str = os.path.join(
+                stage_info["location"], src_file_name
+            )
             self.full_dst_file_name = os.path.join(
-                meta.local_location, meta.dst_file_name
+                meta.local_location, os.path.basename(meta.dst_file_name)
             )
 
     def get_file_header(self, filename: str) -> FileHeader | None:
@@ -64,7 +69,7 @@ def download_chunk(self, chunk_id: int) -> None:
                     tfd.write(sfd.read(self.chunk_size))
 
     def finish_download(self) -> None:
-        shutil.copyfile(self.intermediate_dst_path, self.full_dst_file_name)
+        shutil.move(self.intermediate_dst_path, self.full_dst_file_name)
         self.meta.dst_file_size = os.stat(self.full_dst_file_name).st_size
         self.meta.result_status = ResultStatus.DOWNLOADED
 

test/unit/test_local_storage_client.py

@@ -58,7 +58,7 @@ def test_multi_chunk_download(multipart_threshold):
 
         meta = SnowflakeFileMeta(
             name=file_name,
-            src_file_name=str(stage_file),
+            src_file_name=str(file_name),
             stage_location_type=LOCAL_FS,
             dst_file_name=file_name,
             local_location=local_dir,