NO-SNOW: Comments of weirds

Author: sfc-gh-fpawlowski

src/snowflake/connector/session_manager.py

@@ -615,6 +615,10 @@ class ProxySessionManager(SessionManager):
     def make_session(self, *, url: str | None = None) -> Session:
         session = requests.Session()
         self._mount_adapters(session)
+
+        # TODO: adding this makes all proxies "not see the requests" - but they actually go since we can see MATCHED-stub id
+        # session.trust_env = False
+
         proxies = (
             {
                 "no_proxy": self._cfg.no_proxy,

test/unit/test_proxies.py

@@ -807,11 +807,13 @@ def test_proxy_env_vars_take_precedence_over_connection_params(
     clear_proxy_env_vars()  # Clear any existing ones first
 
     env_proxy_url = f"http://{proxy_from_env_vars.wiremock_host}:{proxy_from_env_vars.wiremock_http_port}"
+    # TODO: commenting out this makes conn_params behave normally and be used
     monkeypatch.setenv("HTTP_PROXY", env_proxy_url)
     monkeypatch.setenv("HTTPS_PROXY", env_proxy_url)
 
     # Set connection params to point to proxy1 (should take precedence)
     connect_kwargs = _base_connect_kwargs(target_wm)
+    # TODO: commenting out this: connect_kwargs.update(... doesn't seem to change a thing - both proxies and the target still see all requests
     connect_kwargs.update(
         {
             "proxy_host": proxy_from_conn_params.wiremock_host,