Skip to content

Commit b5b375d

Browse files
committed
SNOW-27588: removed an explicit DNS lookup for OCSP URL
1 parent 226a27f commit b5b375d

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

ocsp_pyopenssl.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -539,25 +539,25 @@ def execute_ocsp_request(ocsp_uri, cert_id, proxies=None, do_retry=True):
539539
# transform objects into data in requests
540540
data = der_encoder.encode(ocsp_request)
541541
parsed_url = urlsplit(ocsp_uri)
542-
ip = socket.gethostbyname(parsed_url.hostname)
543-
new_uri = urlunsplit((parsed_url.scheme, ip, parsed_url.path,
544-
parsed_url.query, parsed_url.fragment))
545542
session = requests.Session()
546543
session.mount('http://', HTTPAdapter(max_retries=5))
547544
session.mount('https://', HTTPAdapter(max_retries=5))
548545

549546
max_retry = 100 if do_retry else 1
550547
# NOTE: This retry is to retry getting HTTP 200.
548+
headers = {
549+
'Content-Type': 'application/ocsp-request',
550+
'Content-Length': '{0}'.format(
551+
len(data)),
552+
'Host': parsed_url.hostname.encode(
553+
'utf-8'),
554+
}
555+
logger.debug('url: %s, headers: %s, proxies: %s',
556+
ocsp_uri, headers, proxies)
551557
for attempt in range(max_retry):
552558
response = session.post(
553-
new_uri,
554-
headers={
555-
'Content-Type': 'application/ocsp-request',
556-
'Content-Length': '{0}'.format(
557-
len(data)),
558-
'Host': parsed_url.hostname.encode(
559-
'utf-8'),
560-
},
559+
ocsp_uri,
560+
headers=headers,
561561
proxies=proxies,
562562
data=data)
563563
if response.status_code == OK:

ssl_wrap_socket.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -471,9 +471,13 @@ def ssl_wrap_socket_with_ocsp(
471471
ca_certs=ca_certs, server_hostname=server_hostname,
472472
ssl_version=ssl_version)
473473
logger = getLogger(__name__)
474-
logger.info(u'insecure_mode: %s, OCSP response cache file name: %s',
474+
logger.info(u'insecure_mode: %s, '
475+
u'OCSP response cache file name: %s, '
476+
u'PROXY_HOST: %s, PROXY_PORT: %s, PROXY_USER: %s '
477+
u'PROXY_PASSWORD: %s',
475478
FEATURE_INSECURE_MODE,
476-
FEATURE_OCSP_RESPONSE_CACHE_FILE_NAME)
479+
FEATURE_OCSP_RESPONSE_CACHE_FILE_NAME,
480+
PROXY_HOST, PROXY_PORT, PROXY_USER, PROXY_PASSWORD)
477481
if not FEATURE_INSECURE_MODE:
478482
v = SnowflakeOCSP(
479483
proxies=set_proxies(PROXY_HOST, PROXY_PORT, PROXY_USER,

0 commit comments

Comments
 (0)