SNOW-1922893: Remove Windows permissions check (#2173)

Author: sfc-gh-pbulawa

DESCRIPTION.md

@@ -16,6 +16,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
   - Added support for iceberg tables to `write_pandas`.
   - Fixed base64 encoded private key tests.
   - Added Wiremock tests.
+  - Fixed a bug where file permission check happened on Windows
 
 - v3.13.2(January 29, 2025)
   - Changed not to use scoped temporary objects.

src/snowflake/connector/config_manager.py

@@ -330,7 +330,8 @@ def read_config(
                 continue
 
             if (
-                sliceoptions.check_permissions  # Skip checking if this file couldn't hold sensitive information
+                not IS_WINDOWS  # Skip checking on Windows
+                and sliceoptions.check_permissions  # Skip checking if this file couldn't hold sensitive information
                 # Same check as openssh does for permissions
                 # https://github.com/openssh/openssh-portable/blob/2709809fd616a0991dc18e3a58dea10fb383c3f0/readconf.c#LL2264C1-L2264C1
                 and filep.stat().st_mode & READABLE_BY_OTHERS != 0
@@ -341,12 +342,7 @@ def read_config(
                     and filep.stat().st_uid != os.getuid()
                 )
             ):
-                # for non-Windows, suggest change to 0600 permissions.
-                chmod_message = (
-                    f'.\n * To change owner, run `chown $USER "{str(filep)}"`.\n * To restrict permissions, run `chmod 0600 "{str(filep)}"`.\n'
-                    if not IS_WINDOWS
-                    else ""
-                )
+                chmod_message = f'.\n * To change owner, run `chown $USER "{str(filep)}"`.\n * To restrict permissions, run `chmod 0600 "{str(filep)}"`.\n'
 
                 warn(f"Bad owner or permissions on {str(filep)}{chmod_message}")
             LOGGER.debug(f"reading configuration file from {str(filep)}")

test/unit/test_configmanager.py

@@ -575,6 +575,7 @@ def test_warn_config_file_owner(tmp_path, monkeypatch):
         )
 
 
+@pytest.mark.skipif(IS_WINDOWS, reason="chmod doesn't work on Windows")
 def test_warn_config_file_permissions(tmp_path):
     c_file = tmp_path / "config.toml"
     c1 = ConfigManager(file_path=c_file, name="root_parser")
@@ -590,17 +591,30 @@ def test_warn_config_file_permissions(tmp_path):
     with warnings.catch_warnings(record=True) as c:
         assert c1["b"] is True
     assert len(c) == 1
-    chmod_message = (
-        f'.\n * To change owner, run `chown $USER "{str(c_file)}"`.\n * To restrict permissions, run `chmod 0600 "{str(c_file)}"`.\n'
-        if not IS_WINDOWS
-        else ""
-    )
+    chmod_message = f'.\n * To change owner, run `chown $USER "{str(c_file)}"`.\n * To restrict permissions, run `chmod 0600 "{str(c_file)}"`.\n'
     assert (
         str(c[0].message)
         == f"Bad owner or permissions on {str(c_file)}" + chmod_message
     )
 
 
+@pytest.mark.skipif(not IS_WINDOWS, reason="Windows specific test")
+def test_warn_config_file_permissions_windows(tmp_path):
+    c_file = tmp_path / "config.toml"
+    c1 = ConfigManager(file_path=c_file, name="root_parser")
+    c1.add_option(name="b", parse_str=lambda e: e.lower() == "true")
+    c_file.write_text(
+        dedent(
+            """\
+            b = true
+            """
+        )
+    )
+    with warnings.catch_warnings(record=True) as c:
+        assert c1["b"] is True
+    assert len(c) == 0
+
+
 @pytest.mark.skipif(IS_WINDOWS, reason="chmod doesn't work on Windows")
 def test_log_debug_config_file_parent_dir_permissions(tmp_path, caplog):
     tmp_dir = tmp_path / "tmp_dir"