Adjust binging security test to server behavioral change (#2588)

Author: sfc-gh-pczajka

test/csp_helpers.py

@@ -446,7 +446,3 @@ def __enter__(self):
     def __exit__(self, *args, **kwargs):
         self.os_environment_patch.__exit__(*args)
         super().__exit__(*args, **kwargs)
-
-
-def is_running_against_gcp():
-    return os.getenv("cloud_provider").lower() == "gcp"

test/integ/test_cursor_binding.py

@@ -1,8 +1,6 @@
 #!/usr/bin/env python
 from __future__ import annotations
 
-from test.csp_helpers import is_running_against_gcp
-
 import pytest
 
 from snowflake.connector.errors import ProgrammingError
@@ -44,22 +42,38 @@ def test_binding_security(conn_cnx, db_parameters):
 
             # SQL injection safe test
             # Good Example
-            if not is_running_against_gcp():
-                with pytest.raises(ProgrammingError):
-                    cnx.cursor().execute(
+            # server behavior change: this no longer raises an error, but returns an empty result set
+            try:
+                res = (
+                    cnx.cursor()
+                    .execute(
                         "SELECT * FROM {name} WHERE aa=%s".format(
                             name=db_parameters["name"]
                         ),
                         ("1 or aa>0",),
                     )
-
-                with pytest.raises(ProgrammingError):
-                    cnx.cursor().execute(
+                    .fetchall()
+                )
+                assert res == []
+            except ProgrammingError:
+                # old server behavior: OK
+                pass
+
+            try:
+                res = (
+                    cnx.cursor()
+                    .execute(
                         "SELECT * FROM {name} WHERE aa=%(aa)s".format(
                             name=db_parameters["name"]
                         ),
                         {"aa": "1 or aa>0"},
                     )
+                    .fetchall()
+                )
+                assert res == []
+            except ProgrammingError:
+                # old server behavior: OK
+                pass
 
             # Bad Example in application. DON'T DO THIS
             c = cnx.cursor()