SNOW-2021009: Improving CICD, flakiness fixes (#2569)

Author: sfc-gh-pcyrek

.github/workflows/build_test.yml

@@ -18,6 +18,14 @@ on:
             required: true
           tags:
             description: "Test scenario tags"
+            required: false
+            type: string
+
+permissions:
+  contents: read
+  actions: read
+  checks: write
+  pull-requests: write
 
 concurrency:
   # older builds for the same pull request number or branch should be cancelled
@@ -216,7 +224,6 @@ jobs:
        # To run a single test on GHA use the below command:
 #        run: python -m tox run -e `echo py${PYTHON_VERSION/\./}-single-ci | sed 's/ /,/g'`
         run: python -m tox run -e `echo py${PYTHON_VERSION/\./}-{extras,unit-parallel,integ-parallel,pandas-parallel,sso}-ci | sed 's/ /,/g'`
-
         env:
           PYTHON_VERSION: ${{ matrix.python-version }}
           cloud_provider: ${{ matrix.cloud-provider }}
@@ -225,17 +232,16 @@ jobs:
          # To specify the test name (in single test mode) pass this env variable:
 #          SINGLE_TEST_NAME: test/path/filename.py::test_name
         shell: bash
-      - name: Combine coverages
-        run: python -m tox run -e coverage --skip-missing-interpreters false
-        shell: bash
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: coverage_${{ matrix.os.download_name }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
           path: |
             .tox/.coverage
             .tox/coverage.xml
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: junit_${{ matrix.os.download_name }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
@@ -363,13 +369,15 @@ jobs:
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: coverage_linux-fips-3.9-${{ matrix.cloud-provider }}
           path: |
             .coverage
             coverage.xml
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: junit_linux-fips-3.9-${{ matrix.cloud-provider }}
@@ -423,21 +431,23 @@ jobs:
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: coverage_linux-lambda-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
           path: |
             .coverage.py${{ env.shortver }}-lambda-ci
             junit.py${{ env.shortver }}-lambda-ci-dev.xml
       - uses: actions/upload-artifact@v4
+        if: always()
         with:
           include-hidden-files: true
           name: junit_linux-lambda-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
           path: |
             junit.py${{ env.shortver }}-lambda-ci-dev.xml
 
   combine-coverage:
-    if: ${{ success() || failure() }}
+    if: always()
     name: Combine coverage
     needs: [lint, test, test-fips, test-lambda]
     runs-on: ubuntu-latest
@@ -469,6 +479,7 @@ jobs:
               dst_file = dst_dir / ".coverage.{}".format(src_file.parent.name[9:])
               print("{} copy to {}".format(src_file, dst_file))
               shutil.copy(str(src_file), str(dst_file))'
+
       - name: Collect all JUnit XML files to one dir
         run: |
           python -c '
@@ -478,33 +489,43 @@ jobs:
           src_dir = Path("artifacts")
           dst_dir = Path(".") / "junit_results"
           dst_dir.mkdir()
-          # Collect all JUnit XML files with different naming patterns
-          for pattern in ["*/junit.*.xml", "*/junit.py*-lambda-ci-dev.xml"]:
-              for src_file in src_dir.glob(pattern):
-                  dst_file = dst_dir / src_file.name
-                  print("{} copy to {}".format(src_file, dst_file))
-                  shutil.copy(str(src_file), str(dst_file))'
+          for src_file in src_dir.glob("*/junit*.xml"):
+              artifact_name = src_file.parent.name
+              dst_file = dst_dir / f"{artifact_name}_{src_file.name}"
+              print("{} copy to {}".format(src_file, dst_file))
+              shutil.copy(str(src_file), str(dst_file))'
       - name: Combine coverages
-        run: python -m tox run -e coverage
+        run: |
+          if [ -d ".tox" ] && [ "$(find .tox -name ".coverage*" -type f | wc -l)" -gt 0 ]; then
+            python -m tox run -e coverage
+          else
+            echo "No coverage files found, skipping coverage combination"
+          fi
       - name: Publish html coverage
+        if: ${{ success() }}
         uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
           name: overall_cov_html
           path: .tox/htmlcov
       - name: Publish xml coverage
+        if: ${{ success() }}
         uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
           name: overall_cov_xml
           path: .tox/coverage.xml
       - uses: codecov/codecov-action@v4
+        if: ${{ success() }}
         with:
           files: .tox/coverage.xml
           token: ${{ secrets.CODECOV_TOKEN }}
+          name: coverage-${{ github.run_id }}
+          fail_ci_if_error: false
+          verbose: true
       - name: Upload test results to Codecov
         if: ${{ !cancelled() }}
         uses: codecov/test-results-action@v1
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: junit_results/junit.*.xml
+          files: junit_results/*.xml

tox.ini

@@ -164,7 +164,7 @@ depends = py39, py310, py311, py312, py313
 [pytest]
 log_level = info
 addopts = -ra --strict-markers
-junit_family = legacy
+junit_family = xunit2
 filterwarnings =
     error::UserWarning:cryptography.*
     error::cryptography.utils.CryptographyDeprecationWarning