NO-SNOW add flag for local test setup (#2397)

Author: sfc-gh-pczajka

test/integ/conftest.py

@@ -95,6 +95,11 @@ def is_public_testaccount() -> bool:
     return running_on_public_ci() or db_parameters["account"].startswith("sfctest0")
 
 
+@pytest.fixture(scope="session")
+def is_local_dev_setup(db_parameters) -> bool:
+    return db_parameters.get("is_local_dev_setup", False)
+
+
 @pytest.fixture(scope="session")
 def db_parameters() -> dict[str, str]:
     return get_db_parameters()

test/integ/test_connection.py

@@ -1370,7 +1370,9 @@ def test_server_session_keep_alive(conn_cnx):
 
 
 @pytest.mark.skipolddriver
-def test_ocsp_mode_disable_ocsp_checks(conn_cnx, is_public_test, caplog):
+def test_ocsp_mode_disable_ocsp_checks(
+    conn_cnx, is_public_test, is_local_dev_setup, caplog
+):
     caplog.set_level(logging.DEBUG, "snowflake.connector.ocsp_snowflake")
     with conn_cnx(disable_ocsp_checks=True) as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
@@ -1379,75 +1381,69 @@ def test_ocsp_mode_disable_ocsp_checks(conn_cnx, is_public_test, caplog):
 
     with conn_cnx() as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
-        if is_public_test:
+        if is_public_test or is_local_dev_setup:
             assert "snowflake.connector.ocsp_snowflake" in caplog.text
             assert "This connection does not perform OCSP checks." not in caplog.text
         else:
             assert "snowflake.connector.ocsp_snowflake" not in caplog.text
 
 
 @pytest.mark.skipolddriver
-def test_ocsp_mode_insecure_mode(conn_cnx, is_public_test, caplog):
+def test_ocsp_mode_insecure_mode(conn_cnx, is_public_test, is_local_dev_setup, caplog):
     caplog.set_level(logging.DEBUG, "snowflake.connector.ocsp_snowflake")
     with conn_cnx(insecure_mode=True) as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
-        if is_public_test:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        if is_public_test or is_local_dev_setup:
             assert "This connection does not perform OCSP checks." in caplog.text
-        else:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
 
 
 @pytest.mark.skipolddriver
 def test_ocsp_mode_insecure_mode_and_disable_ocsp_checks_match(
-    conn_cnx, is_public_test, caplog
+    conn_cnx, is_public_test, is_local_dev_setup, caplog
 ):
     caplog.set_level(logging.DEBUG, "snowflake.connector.ocsp_snowflake")
     with conn_cnx(
         insecure_mode=True, disable_ocsp_checks=True
     ) as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
-        if is_public_test:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        if is_public_test or is_local_dev_setup:
             assert (
                 "The values for 'disable_ocsp_checks' and 'insecure_mode' differ. "
                 "Using the value of 'disable_ocsp_checks."
             ) not in caplog.text
             assert "This connection does not perform OCSP checks." in caplog.text
-        else:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
 
 
 @pytest.mark.skipolddriver
 def test_ocsp_mode_insecure_mode_and_disable_ocsp_checks_mismatch_ocsp_disabled(
-    conn_cnx, is_public_test, caplog
+    conn_cnx, is_public_test, is_local_dev_setup, caplog
 ):
     caplog.set_level(logging.DEBUG, "snowflake.connector.ocsp_snowflake")
     with conn_cnx(
         insecure_mode=False, disable_ocsp_checks=True
     ) as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
-        if is_public_test:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        assert "snowflake.connector.ocsp_snowflake" not in caplog.text
+        if is_public_test or is_local_dev_setup:
             assert (
                 "The values for 'disable_ocsp_checks' and 'insecure_mode' differ. "
                 "Using the value of 'disable_ocsp_checks."
             ) in caplog.text
             assert "This connection does not perform OCSP checks." in caplog.text
-        else:
-            assert "snowflake.connector.ocsp_snowflake" not in caplog.text
 
 
 @pytest.mark.skipolddriver
 def test_ocsp_mode_insecure_mode_and_disable_ocsp_checks_mismatch_ocsp_enabled(
-    conn_cnx, is_public_test, caplog
+    conn_cnx, is_public_test, is_local_dev_setup, caplog
 ):
     caplog.set_level(logging.DEBUG, "snowflake.connector.ocsp_snowflake")
     with conn_cnx(
         insecure_mode=True, disable_ocsp_checks=False
     ) as conn, conn.cursor() as cur:
         assert cur.execute("select 1").fetchall() == [(1,)]
-        if is_public_test:
+        if is_public_test or is_local_dev_setup:
             assert "snowflake.connector.ocsp_snowflake" in caplog.text
             assert (
                 "The values for 'disable_ocsp_checks' and 'insecure_mode' differ. "