Skip to content

Commit e1f149e

Browse files
SNOW-2043816: different puts for multipart and normal
1 parent 828ed88 commit e1f149e

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

test/integ/test_http_interceptor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ def _assert_expected_requests_occurred(conn: SnowflakeConnection) -> None:
210210
tracker.assert_aws_get_accelerate_issued(optional=True)
211211

212212
tracker.assert_file_head_issued(test_file.name)
213-
tracker.assert_put_file_issued(cloud_platform=current_provider)
213+
tracker.assert_put_file_issued(filename=test_file.name)
214214

215215
get_sql = f"GET @{stage_name}/{test_file.name} file://{download_dir}"
216216
cursor.execute(get_sql)

test/test_utils/http_test_utils.py

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,27 @@ def assert_get_file_issued(
291291
)
292292

293293
def assert_put_file_issued(
294+
self,
295+
filename: Optional[str] = None,
296+
expected_headers: Union[Dict[str, Any], Tuple[Tuple[str, Any], ...]] = (
297+
("test-header", "test-value"),
298+
),
299+
sequentially: bool = True,
300+
optional: bool = False,
301+
) -> Optional[RequestDTO]:
302+
return self._assert_issued_with_custom_headers(
303+
ExpectedRequestInfo(
304+
"PUT",
305+
r".*(s3(.*)?\.amazonaws|blob\.core\.windows|storage\.googleapis).*stages.*"
306+
+ (filename or "")
307+
+ r"(.*)?",
308+
),
309+
expected_headers,
310+
sequentially,
311+
optional,
312+
)
313+
314+
def assert_put_file_part_in_multipart_issued(
294315
self,
295316
filename: Optional[str] = None,
296317
cloud_platform: Union[str, None] = None,
@@ -434,10 +455,10 @@ def assert_multiple_put_file_issued(
434455
sequentially: bool = True,
435456
optional: bool = True,
436457
) -> None:
437-
self.assert_put_file_issued(
458+
self.assert_put_file_part_in_multipart_issued(
438459
filename, cloud_platform, expected_headers, sequentially=sequentially
439460
)
440-
while self.assert_put_file_issued(
461+
while self.assert_put_file_part_in_multipart_issued(
441462
filename,
442463
cloud_platform,
443464
expected_headers,

0 commit comments

Comments
 (0)