SNOW-2048239 revert zero timeout for oscp cache lock (#2283)

Author: sfc-gh-mmishchenko

DESCRIPTION.md

@@ -27,6 +27,7 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
   - Improved security and robustness for the temporary credentials cache storage.
   - Fixed a bug that caused driver to fail silently on `TO_DATE` arrow to python conversion when invalid date was followed by the correct one.
   - Fixed expired S3 credentials update and increment retry when expired credentials are found.
+  - Deprecated `insecure_mode` connection property and replaced it with `disable_ocsp_checks` with the same behavior as the former property.
 
 - v3.14.0(March 03, 2025)
   - Bumped pyOpenSSL dependency upper boundary from <25.0.0 to <26.0.0.
@@ -38,7 +39,6 @@ Source code is also available at: https://github.com/snowflakedb/snowflake-conne
   - Fixed a bug where file permission check happened on Windows.
   - Added support for File types.
   - Added `unsafe_file_write` connection parameter that restores the previous behaviour of saving files downloaded with GET with 644 permissions.
-  - Deprecated `insecure_mode` connection property and replaced it with `disable_ocsp_checks` with the same behavior as the former property.
 
 - v3.13.2(January 29, 2025)
   - Changed not to use scoped temporary objects.

src/snowflake/connector/ocsp_snowflake.py

@@ -227,7 +227,6 @@ def _deserialize(cls, opened_fd) -> _OCSPResponseValidationResultCache:
         OCSPResponseValidationResult,
     ] = _OCSPResponseValidationResultCache(
         entry_lifetime=constants.DAY_IN_SECONDS,
-        file_timeout=60.0,
         file_path={
             "linux": os.path.join(
                 "~", ".cache", "snowflake", "ocsp_response_validation_cache.json"

test/unit/test_ocsp.py

@@ -257,7 +257,6 @@ def test_ocsp_bad_validity():
     del environ["SF_TEST_OCSP_FORCE_BAD_RESPONSE_VALIDITY"]
 
 
-@pytest.mark.flaky(reruns=3)
 def test_ocsp_single_endpoint():
     environ["SF_OCSP_ACTIVATE_NEW_ENDPOINT"] = "True"
     SnowflakeOCSP.clear_cache()
@@ -281,7 +280,6 @@ def test_ocsp_by_post_method():
         assert ocsp.validate(url, connection), f"Failed to validate: {url}"
 
 
-@pytest.mark.flaky(reruns=3)
 def test_ocsp_with_file_cache(tmpdir):
     """OCSP tests and the cache server and file."""
     tmp_dir = str(tmpdir.mkdir("ocsp_response_cache"))
@@ -295,7 +293,6 @@ def test_ocsp_with_file_cache(tmpdir):
         assert ocsp.validate(url, connection), f"Failed to validate: {url}"
 
 
-@pytest.mark.flaky(reruns=3)
 @pytest.mark.skipolddriver
 def test_ocsp_with_bogus_cache_files(tmpdir, random_ocsp_response_validation_cache):
     with mock.patch(
@@ -335,7 +332,6 @@ def test_ocsp_with_bogus_cache_files(tmpdir, random_ocsp_response_validation_cac
             )
 
 
-@pytest.mark.flaky(reruns=3)
 @pytest.mark.skipolddriver
 def test_ocsp_with_outdated_cache(tmpdir, random_ocsp_response_validation_cache):
     with mock.patch(
@@ -396,7 +392,6 @@ def _store_cache_in_file(tmpdir, target_hosts=None):
     return filename, target_hosts
 
 
-@pytest.mark.flaky(reruns=3)
 def test_ocsp_with_invalid_cache_file():
     """OCSP tests with an invalid cache file."""
     SnowflakeOCSP.clear_cache()  # reset the memory cache
@@ -406,7 +401,6 @@ def test_ocsp_with_invalid_cache_file():
         assert ocsp.validate(url, connection), f"Failed to validate: {url}"
 
 
-@pytest.mark.flaky(reruns=3)
 @mock.patch(
     "snowflake.connector.ocsp_snowflake.SnowflakeOCSP._fetch_ocsp_response",
     side_effect=BrokenPipeError("fake error"),
@@ -429,7 +423,6 @@ def test_ocsp_cache_when_server_is_down(
         assert not cache_data, "no cache should present because of broken pipe"
 
 
-@pytest.mark.flaky(reruns=3)
 def test_concurrent_ocsp_requests(tmpdir):
     """Run OCSP revocation checks in parallel. The memory and file caches are deleted randomly."""
     cache_file_name = path.join(str(tmpdir), "cache_file.txt")
@@ -474,7 +467,6 @@ def test_ocsp_revoked_certificate():
     assert ex.value.errno == ex.value.errno == ER_OCSP_RESPONSE_CERT_STATUS_REVOKED
 
 
-@pytest.mark.flaky(reruns=3)
 def test_ocsp_incomplete_chain():
     """Tests incomplete chained certificate."""
     incomplete_chain_cert = path.join(