Skip to content

fix: removing trailing slash from oauth_redirect_uri#2341

Merged
sfc-gh-mmishchenko merged 2 commits intosnowflakedb:mainfrom
sfc-gh-mborins:patch-1
Jun 26, 2025
Merged

fix: removing trailing slash from oauth_redirect_uri#2341
sfc-gh-mmishchenko merged 2 commits intosnowflakedb:mainfrom
sfc-gh-mborins:patch-1

Conversation

@sfc-gh-mborins
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    I didn't open an issue

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    The trailing slash breaks the OAUTH_AUTHORIZATION_CODE flow for LOCAL_APPLICATION. Removing this trailing slash enables the flow to work properly.

  4. (Optional) PR for stored-proc connector:

The trailing slash breaks the OAUTH_AUTHORIZATION_CODE
flow for LOCAL_APPLICATION. Removing this trailing slash
enables the flow to work properly.
@github-actions
Copy link

github-actions bot commented May 27, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (sfc-gh-fpawlowski)[https://github.com/sfc-gh-fpawlowski]
@sfc-gh-mborins
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-mborins
Copy link
Contributor Author

sfc-gh-mborins commented May 27, 2025 via email

@sfc-gh-mmishchenko sfc-gh-mmishchenko enabled auto-merge (rebase) June 26, 2025 08:14
@sfc-gh-mmishchenko sfc-gh-mmishchenko added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP labels Jun 26, 2025
@sfc-gh-mmishchenko sfc-gh-mmishchenko merged commit 1062e1e into snowflakedb:main Jun 26, 2025
39 of 95 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants