fix: removing trailing slash from oauth_redirect_uri#2341
Merged
sfc-gh-mmishchenko merged 2 commits intosnowflakedb:mainfrom Jun 26, 2025
Merged
fix: removing trailing slash from oauth_redirect_uri#2341sfc-gh-mmishchenko merged 2 commits intosnowflakedb:mainfrom
sfc-gh-mmishchenko merged 2 commits intosnowflakedb:mainfrom
Conversation
The trailing slash breaks the OAUTH_AUTHORIZATION_CODE flow for LOCAL_APPLICATION. Removing this trailing slash enables the flow to work properly.
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA
Myles Borins
Product Lead, Developer Platform
Pronouns: He / Him / His
Snowflake Inc.
16 York St Suite 3100-3200
Toronto, On M5J 0E6
…On Tue, May 27, 2025, 10:33 a.m. github-actions[bot] < ***@***.***> wrote:
*github-actions[bot]* left a comment
(snowflakedb/snowflake-connector-python#2341)
<#2341 (comment)>
Thank you for your submission, we really appreciate it. Like many
open-source projects, we ask that you sign our Contributor License
Agreement <https://github.com/snowflakedb/CLA/blob/main/README.md> before
we can accept your contribution. You can sign the CLA by just posting a
Pull Request Comment same as the below format.
------------------------------
I have read the CLA Document and I hereby sign the CLA
------------------------------
You can retrigger this bot by commenting *recheck* in this Pull Request. Posted
by the *CLA Assistant Lite bot*.
—
Reply to this email directly, view it on GitHub
<#2341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMBBHMDDZYWBVD35MIWUIML3ARZVPAVCNFSM6AAAAAB6AHSUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJSG42TIMRVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sfc-gh-mmishchenko
approved these changes
May 28, 2025
sfc-gh-pbulawa
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
I didn't open an issue
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The trailing slash breaks the OAUTH_AUTHORIZATION_CODE flow for LOCAL_APPLICATION. Removing this trailing slash enables the flow to work properly.
(Optional) PR for stored-proc connector: