Cherrypicks to aio connector part4#2425
Merged
sfc-gh-pczajka merged 8 commits intodev/aio-connectorfrom Aug 4, 2025
Merged
Conversation
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part3
branch
from
e0539cf to
de3a4c1
Compare
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part4
branch
from
c8eb013 to
c40d89b
Compare
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part3
branch
from
de3a4c1 to
ca5e175
Compare
Contributor
|
Just quick heads-up - there seems to be some conflict between the branches. |
Base automatically changed from
cherrypicks-to-aio-connector-part3
to
dev/aio-connector
July 30, 2025 13:57
Co-authored-by: Jenkins User <900904>
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part4
branch
from
c40d89b to
7ad3c8d
Compare
|
|
||
|
|
||
| # Although this is an unit test, we put it under test/integ/sso, since it needs keyring package installed | ||
| @pytest.mark.skipif( |
Contributor
There was a problem hiding this comment.
That's a great catch. Those tests weren't probably running since that refactor at all..
Only it would be great to move this commit into separate PR into the main branch, to minimise the final difference between the main branch and the dev/aio-connector (apart from the aio module).
Contributor
There was a problem hiding this comment.
Apart from this all looks good 👍
Collaborator
Author
There was a problem hiding this comment.
This turned out to cause cascade of issues, I've created a separate ticket for that: https://snowflakecomputing.atlassian.net/browse/SNOW-2236300
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part4
branch
from
7ad3c8d to
c9cc9c9
Compare
sfc-gh-pczajka
force-pushed
the
cherrypicks-to-aio-connector-part4
branch
from
e808119 to
fdf6753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor usage of removed function "delete_temporary_credentials" in tests-> https://snowflakecomputing.atlassian.net/browse/SNOW-2236300