SNOW-896926 adjust vendored urllib3 and requests#2505
Merged
sfc-gh-pczajka merged 7 commits intoSNOW-896926-upgrade-vendored-urllib3-and-requestsfrom Sep 19, 2025
Conversation
sfc-gh-mmishchenko
force-pushed
the
SNOW-896926-upgrade-vendored-urllib3-and-requests
branch
2 times, most recently
from
9f3d417 to
2e84e1b
Compare
| from .. import urllib3 | ||
|
|
||
| from .exceptions import RequestsDependencyWarning | ||
|
|
Contributor
There was a problem hiding this comment.
Below in this file we have 2 more imports from urllib3 (line 131 and 143) - did we deliberately leave those unchanged?
| from ..urllib3.util.retry import Retry | ||
|
|
||
| from .auth import _basic_auth_str | ||
| from .compat import basestring, urlparse |
Contributor
There was a problem hiding this comment.
In line 59 we have from urllib3.contrib.socks import SOCKSProxyManager - was it intentional?
Contributor
There was a problem hiding this comment.
We also have:
- one in line 24 of help.py
- one in contrib/emscripten/init.py -> import urllib3.connection
Contributor
|
Do we know a source of the |
sfc-gh-pczajka
force-pushed
the
SNOW-896926-upgrade-vendored-urllib3-and-requests
branch
from
2e84e1b to
e5d14e0
Compare
sfc-gh-pczajka
force-pushed
the
SNOW-896926-adjust-vendored-urllib3-and-requests
branch
from
9aa9f9d to
c208c4b
Compare
| "and could be missing the host." | ||
| ) | ||
| proxy_manager = self.proxy_manager_for(proxy) | ||
|
|
Collaborator
There was a problem hiding this comment.
The piece of logic below is the custom one we introduced. Can we override proxy_manager_for instead and avoid isinstance call?
| ca_certs_in_args = len(args) > ca_certs_index | ||
|
|
||
| if not isinstance(ssl_context, PyOpenSSLContext): | ||
| if FEATURE_OCSP_MODE != OCSPMode.DISABLE_OCSP_CHECKS: |
Collaborator
There was a problem hiding this comment.
I need more explanation on this before I approve
sfc-gh-pczajka
force-pushed
the
SNOW-896926-upgrade-vendored-urllib3-and-requests
branch
from
3687964 to
78955fb
Compare
sfc-gh-pczajka
force-pushed
the
SNOW-896926-adjust-vendored-urllib3-and-requests
branch
from
c0eae8e to
4fb6b3e
Compare
sfc-gh-jszczerbinski
approved these changes
Sep 19, 2025
sfc-gh-pczajka
merged commit 0c67a10
into
SNOW-896926-upgrade-vendored-urllib3-and-requests
123 of 182 checks passed
sfc-gh-pczajka
deleted the
SNOW-896926-adjust-vendored-urllib3-and-requests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: