Skip to content

Add WIF impersonation path length as data sent to Snowflake backend#2521

Merged
sfc-gh-eqin merged 5 commits intomainfrom
eqin-impersonation-path-length-json
Sep 22, 2025
Merged

Add WIF impersonation path length as data sent to Snowflake backend#2521
sfc-gh-eqin merged 5 commits intomainfrom
eqin-impersonation-path-length-json

Conversation

@sfc-gh-eqin
Copy link
Contributor

@sfc-gh-eqin sfc-gh-eqin commented Sep 5, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    https://snowflakecomputing.atlassian.net/browse/SNOW-2321708

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

It helps to have more metrics for new features. WIF impersonation was introduced in #2496

Please write a short description of how your code change solves the related issue.

  1. (Optional) PR for stored-proc connector:

@sfc-gh-eqin Graphite App
Copy link
Contributor Author

sfc-gh-eqin commented Sep 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-eqin sfc-gh-eqin marked this pull request as ready for review September 5, 2025 21:49
@sfc-gh-eqin sfc-gh-eqin requested a review from a team as a code owner September 5, 2025 21:49
sfc-gh-pmansour
sfc-gh-pmansour approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-pmansour sfc-gh-pmansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a high level

@sfc-gh-eqin sfc-gh-eqin force-pushed the eqin-impersonation-path-length-json branch from 5b3273c to 395928b Compare September 11, 2025 16:08
@sfc-gh-pczajka sfc-gh-pczajka added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 11, 2025
sfc-gh-pmansour
sfc-gh-pmansour previously approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-pmansour sfc-gh-pmansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sfc-gh-pmansour
sfc-gh-pmansour approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-pmansour sfc-gh-pmansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edward!

@sfc-gh-eqin sfc-gh-eqin merged commit 547c4b7 into main Sep 22, 2025
95 of 100 checks passed
@sfc-gh-eqin sfc-gh-eqin deleted the eqin-impersonation-path-length-json branch September 22, 2025 16:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

+1 more reviewer

@sfc-gh-pmansour sfc-gh-pmansour sfc-gh-pmansour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-eqin @sfc-gh-pczajka @sfc-gh-pmansour