CP: SNOW-2333702 Fix types for DictCursor (#2532) #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-turbaszek
force-pushed
the
turbaszek-aio-cp-6
branch
from
b2e6431 to
842692b
Compare
Co-authored-by: Patryk Czajka <[email protected]>
sfc-gh-turbaszek
force-pushed
the
turbaszek-aio-cp-6
branch
from
842692b to
2c9cb4e
Compare
| ) | ||
| ) | ||
| elif errno == OAUTH_ACCESS_TOKEN_EXPIRED_GS_CODE: | ||
| elif (errno == OAUTH_ACCESS_TOKEN_EXPIRED_GS_CODE) and ( |
There was a problem hiding this comment.
Why was this additional assertion not needed in sync code?
| @pytest.mark.parametrize("cursor_class", [SnowflakeCursor, DictCursor]) | ||
| def test_simple_async(conn_cnx, cursor_class): | ||
| @pytest.mark.parametrize( | ||
| "cursor_class, row_type", [(SnowflakeCursor, tuple), (DictCursor, dict)] |
There was a problem hiding this comment.
This is missing in the async code - file test_async_async.py in integ/aio_it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit was cherry-picked and aio code was adjusted to reflect changes from sync version.