Skip to content

NO-SNOW: Fix flaky CLR test#2507

Merged
sfc-gh-dheyman merged 1 commit intomasterfrom
02-18-fix_flaky_clr_test
Feb 18, 2026
Merged

NO-SNOW: Fix flaky CLR test#2507
sfc-gh-dheyman merged 1 commit intomasterfrom
02-18-fix_flaky_clr_test

Conversation

@sfc-gh-dheyman
Copy link
Collaborator

@sfc-gh-dheyman sfc-gh-dheyman commented Feb 18, 2026

Overview

Fix flaky testCacheManagerPeriodicCleanup test by increasing the cleanup interval from 100ms to 1s and making cache entries clearly older than the removal delay, preventing a race condition where the periodic cleanup task fires before the initial assertions can execute.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-dheyman sfc-gh-dheyman marked this pull request as ready for review February 18, 2026 09:45
@sfc-gh-dheyman sfc-gh-dheyman requested a review from a team as a code owner February 18, 2026 09:45
@sfc-gh-dheyman sfc-gh-dheyman changed the title fix: flaky CLR test NO-SNOW: Fix flaky CLR test Feb 18, 2026
@sfc-gh-dheyman sfc-gh-dheyman merged commit e42f811 into master Feb 18, 2026
158 of 164 checks passed
@sfc-gh-dheyman sfc-gh-dheyman deleted the 02-18-fix_flaky_clr_test branch February 18, 2026 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants