SNOW-132980 quote link parameters correctly

Author: sfc-gh-stakeda

test/test_unit_url.py

@@ -15,6 +15,10 @@ def test_url():
     assert URL(account='testaccount', user='admin',
                password='test') == "snowflake://admin:test@testaccount/"
 
+    assert URL(account='testaccount', user='admin',
+               password='1-pass 2-pass 3-: 4-@ 5-/ 6-pass') == \
+           "snowflake://admin:1-pass 2-pass 3-%3A 4-%40 5-%2F 6-pass@testaccount/"
+
     assert URL(account='testaccount', user='admin',
                password='test', database='testdb') == \
            "snowflake://admin:test@testaccount/testdb"

util.py

@@ -10,6 +10,8 @@
 
 from urllib.parse import quote_plus
 
+from sqlalchemy.engine.url import _rfc_1738_quote
+
 
 def _url(**db_parameters):
     """
@@ -23,7 +25,7 @@ def _url(**db_parameters):
     if 'host' in db_parameters:
         ret = 'snowflake://{user}:{password}@{host}:{port}/'.format(
             user=db_parameters.get('user', ''),
-            password=quote_plus(db_parameters.get('password', '')),
+            password=_rfc_1738_quote(db_parameters.get('password', '')),
             host=db_parameters['host'],
             port=db_parameters['port'] if 'port' in db_parameters else 443,
         )
@@ -32,14 +34,14 @@ def _url(**db_parameters):
         ret = 'snowflake://{user}:{password}@{account}/'.format(
             account=db_parameters['account'],
             user=db_parameters.get('user', ''),
-            password=quote_plus(db_parameters.get('password', '')),
+            password=_rfc_1738_quote(db_parameters.get('password', '')),
         )
         specified_parameters += ['user', 'password', 'account']
     else:
         ret = 'snowflake://{user}:{password}@{account}.{region}/'.format(
             account=db_parameters['account'],
             user=db_parameters.get('user', ''),
-            password=quote_plus(db_parameters.get('password', '')),
+            password=_rfc_1738_quote(db_parameters.get('password', '')),
             region=db_parameters['region'],
         )
         specified_parameters += ['user', 'password', 'account', 'region']