SNOW-679045: _rfc_1738_quote is no longer available in sqlalchemy 1.4.42 (#351)

Author: phillip-parrott

.pre-commit-config.yaml

@@ -44,3 +44,4 @@ repos:
       - id: flake8
         additional_dependencies:
           - flake8-bugbear == 20.11.1
+          - importlib_metadata == 4.13.0

DESCRIPTION.md

@@ -11,6 +11,7 @@ Source code is also available at:
 
 - v1.4.3(Unreleased)
   - Fixed a bug that `SnowflakeDialect.normalize_name` and `SnowflakeDialect.denormalize_name` could not handle empty string.
+  - Fixed a compatibility issue to vendor function `sqlalchemy.engine.url._rfc_1738_quote` as it is removed from SQLAlchemy v1.4.42.
 
 - v1.4.2(Sep 19, 2022)
 

src/snowflake/sqlalchemy/util.py

@@ -2,14 +2,18 @@
 # Copyright (c) 2012-2022 Snowflake Computing Inc. All rights reserved.
 #
 
+import re
 from urllib.parse import quote_plus
 
 from sqlalchemy import exc
-from sqlalchemy.engine.url import _rfc_1738_quote
 
 from snowflake.connector.compat import IS_STR
 
 
+def _rfc_1738_quote(text):
+    return re.sub(r"[:@/]", lambda m: "%%%X" % ord(m.group(0)), text)
+
+
 def _url(**db_parameters):
     """
     Composes a SQLAlchemy connect string from the given database connection