-
Notifications
You must be signed in to change notification settings - Fork 169
update sf connector to < 5.0.0 #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update sf connector to < 5.0.0 #617
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
now that i'm looking at more pending pr's here, it looks like CI is perhaps entirely broken on the repo at the moment |
sparkiegeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good - drive-by comment on the looks-like-a-typo file in snyk/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this file is typo garbage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like someone was trying to remove something related in #605
|
We are also eagerly awaiting this change. Our security scans are now flagging |
this library appears fairly unmaintained at the moment, as CI appears to be broken and nothing is getting merged. I'm sure they will get to it in time. I just refactored a codebase to remove it as a dependency as we werent using a ton of the orm features anyway, just the engine. |
|
@sfc-gh-jvasquezrojas thoughts on merging this and making a release? |
|
any progress on this? |
|
apologies for the long wait on this, but now the library should be in good hands and PRs like this should get attention much quicker in the future. please see the pinned Issue in this repo for this particular change, it is already available since 1.8.0 |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2402222: Dependency constraint on snowflake-connector-python prevents upgrade #615
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
I am mirroring the change made by dependabot which is failing CI likely due to a missing secrets config. I am hoping to see if this one passes CI.