Skip to content

SNOW-2853075: Log SQLAlchemy version #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-jcieslak merged 7 commits into from
Nov 27, 2025
Merged

SNOW-2853075: Log SQLAlchemy version #624

sfc-gh-jcieslak merged 7 commits into from
Nov 27, 2025

Conversation

@sfc-gh-jcieslak
Copy link
Member

@sfc-gh-jcieslak sfc-gh-jcieslak commented Nov 24, 2025 •
edited
Loading

Changes

  • Every time SQLAlchemy establishes a new connection, send the logs about the used SQLAlchemy version
  • Add a unit test with mocks that validates the log is sent on new connections and doesn't break it when any of the logging action fails

@github-actions
Copy link

github-actions bot commented Nov 24, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-jcieslak sfc-gh-jcieslak changed the title SNOW-2853075: Add telemetry SNOW-2853075: Add SQLAlchemy version telemetry Nov 24, 2025
sfc-gh-jcieslak
sfc-gh-jcieslak commented Nov 25, 2025
View reviewed changes
@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review November 25, 2025 08:12
@sfc-gh-jcieslak sfc-gh-jcieslak requested a review from a team as a code owner November 25, 2025 08:12
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title SNOW-2853075: Add SQLAlchemy version telemetry SNOW-2853075: Log SQLAlchemy version Nov 25, 2025
sfc-gh-mraba
sfc-gh-mraba approved these changes Nov 26, 2025
View reviewed changes
@sfc-gh-jcieslak
Copy link
Member Author

sfc-gh-jcieslak commented Nov 27, 2025

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 1926953 into main Nov 27, 2025
44 of 46 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the add-telemetry branch November 27, 2025 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-mraba sfc-gh-mraba sfc-gh-mraba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-jcieslak @sfc-gh-mraba