NO-SNOW: do not use packaging as it's not a dependency in stored proc (#3122)

Author: sfc-gh-aling

src/snowflake/snowpark/_internal/data_source_utils.py

@@ -6,10 +6,10 @@
 import decimal
 import logging
 from enum import Enum
-from packaging import version
 from typing import List, Any, Tuple, Protocol, Optional
 from snowflake.connector.options import pandas as pd
 
+from snowflake.snowpark._internal.utils import get_sorted_key_for_version
 from snowflake.snowpark.exceptions import SnowparkDataframeReaderException
 from snowflake.snowpark.types import (
     StringType,
@@ -313,7 +313,7 @@ def data_source_data_to_pandas_df(
     def df_map_method(pandas_df):
         return (
             pandas_df.applymap
-            if version.parse(pd.__version__) < version.parse("2.1.0")
+            if get_sorted_key_for_version(str(pd.__version__)) < (2, 1, 0)
             else pandas_df.map
         )
 

src/snowflake/snowpark/_internal/utils.py

@@ -1762,3 +1762,15 @@ def merge_multiple_snowflake_plan_expr_to_alias(
             )
 
     return merged_dict
+
+
+def str_contains_alphabet(ver):
+    """Return True if ver contains alphabet, e.g., 1a1; otherwise, return False, e.g., 112"""
+    return bool(re.search("[a-zA-Z]", ver))
+
+
+def get_sorted_key_for_version(version_str):
+    """Generate a key to sort versions. Note if a version component is not a number, e.g., "1a1", we will treat it as -1. E.g., 1.11.1a1 will be treated as 1.11.-1"""
+    return tuple(
+        -1 if str_contains_alphabet(num) else int(num) for num in version_str.split(".")
+    )

tests/unit/test_utils.py

@@ -8,6 +8,8 @@
 import copy
 from snowflake.snowpark._internal.utils import (
     ExprAliasUpdateDict,
+    str_contains_alphabet,
+    get_sorted_key_for_version,
 )
 
 
@@ -101,3 +103,22 @@ def test_expr_alias_update_dict():
         and df_alias_dict1[df_alias_2].was_updated_due_to_inheritance(col_key_1)
         is False
     )
+
+
+def test_str_contains_alphabet():
+    assert str_contains_alphabet("1a1") is True
+    assert str_contains_alphabet("abc") is True
+    assert str_contains_alphabet("123") is False
+    assert str_contains_alphabet("12b34") is True
+    assert str_contains_alphabet(".") is False
+    assert str_contains_alphabet("1.2.3") is False
+
+
+def test_get_sorted_key_for_version():
+    assert get_sorted_key_for_version("1.11.1a1") == (1, 11, -1)
+    assert get_sorted_key_for_version("1.2.3") == (1, 2, 3)
+    assert get_sorted_key_for_version("2.0.0") == (2, 0, 0)
+    assert get_sorted_key_for_version("3.4a.5") == (3, -1, 5)
+    assert get_sorted_key_for_version("10.20.30") == (10, 20, 30)
+    assert get_sorted_key_for_version("4.5.6b7") == (4, 5, -1)
+    assert get_sorted_key_for_version("7.8.9c") == (7, 8, -1)