Skip to content

Commit 07feb45

Browse files
SNOW-2160042: remove redundant validation in iceberg table (#3482)
1 parent ad2e047 commit 07feb45

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
- Added debuggability improvements to show which Python lines an SQL compilation error corresponds to. Enable it using `snowflake.snowpark.context.configure_development_features()`. This feature also depends on AST collection to be enabled in the session which can be done using `session.ast_enabled = True`.
2020
- Set enforce_ordering=True when calling `to_snowpark_pandas()` from a snowpark dataframe containing DML/DDL queries instead of throwing a NotImplementedError.
2121

22+
#### Bug Fixes
23+
24+
- Fixed a bug caused by redundant validation when creating an iceberg table.
25+
2226
### Snowpark Local Testing Updates
2327

2428
#### Bug Fixes

src/snowflake/snowpark/_internal/analyzer/analyzer_utils.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,6 @@ def validate_iceberg_config(iceberg_config: Optional[dict]) -> Dict[str, str]:
224224
return dict()
225225

226226
iceberg_config = {k.lower(): v for k, v in iceberg_config.items()}
227-
if "base_location" not in iceberg_config:
228-
raise ValueError("Iceberg table configuration requires base_location be set.")
229227

230228
return {
231229
EXTERNAL_VOLUME: iceberg_config.get("external_volume", None),

tests/unit/test_analyzer_util_suite.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -400,14 +400,6 @@ def test_join_statement_negative():
400400

401401

402402
def test_create_iceberg_table_statement():
403-
with pytest.raises(
404-
ValueError, match="Iceberg table configuration requires base_location be set."
405-
):
406-
create_table_statement(
407-
table_name="test_table",
408-
schema="test_col varchar",
409-
iceberg_config={},
410-
)
411403
assert create_table_statement(
412404
table_name="test_table",
413405
schema="test_col varchar",

0 commit comments

Comments
 (0)