add test

Author: sfc-gh-yuwang

src/snowflake/snowpark/types.py

@@ -371,9 +371,9 @@ def _fill_ast(self, ast: proto.DataType) -> None:
 # Numeric types
 class _IntegralType(_NumericType):
     def __init__(self, **kwargs) -> None:
-        self._precision = kwargs.get("_precision", None)
+        self._precision = kwargs.pop("_precision", None)
 
-        if kwargs:
+        if kwargs != {}:
             raise TypeError(
                 f"{self.__class__.__name__}() does not accept any arguments, please construct it without parameters."
             )

tests/integ/test_datatypes.py

@@ -429,13 +429,17 @@ def test_numeric_type_store_precision_and_scale(session, massive_number, precisi
             [Decimal(massive_number)],
             StructType([StructField("large_value", DecimalType(precision, 0), True)]),
         )
+        datatype = df.schema.fields[0].datatype
+        assert isinstance(datatype, LongType)
+        assert datatype._precision == precision
+
         df.write.save_as_table(table_name, mode="overwrite", table_type="temp")
         result = session.sql(f"select * from {table_name}")
         datatype = result.schema.fields[0].datatype
         assert isinstance(datatype, LongType)
         assert datatype._precision == 38
     finally:
-        session.sql(f"drop table {table_name}").collect()
+        session.sql(f"drop table if exists {table_name}").collect()
 
 
 @pytest.mark.skipif(