SNOW-2003372: remove python 3.8 (#3189)

sfc-gh-aling · web-flow · commit 18cd1c0f2e2c · 2025-03-31T09:34:34.000-07:00
diff --git a/.github/workflows/daily_precommit.yml b/.github/workflows/daily_precommit.yml
@@ -98,7 +98,7 @@ jobs:
             download_name: macos
           - image_name: windows-latest-64-cores
             download_name: windows
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         cloud-provider: [aws, azure, gcp]
     steps:
       - name: Checkout Code
@@ -167,7 +167,7 @@ jobs:
             .tox/coverage.xml
 
   test-fips:
-    name: Test FIPS py-linux-3.8-${{ matrix.cloud-provider }}
+    name: Test FIPS py-linux-3.9-${{ matrix.cloud-provider }}
     needs: build
     runs-on: ubuntu-latest-64-cores
     strategy:
@@ -194,15 +194,15 @@ jobs:
       - name: Run tests
         run: ./ci/test_fips_docker.sh
         env:
-          PYTHON_VERSION: 3.8
+          PYTHON_VERSION: 3.9
           cloud_provider: ${{ matrix.cloud-provider }}
           PYTEST_ADDOPTS: --color=yes --tb=short
           TOX_PARALLEL_NO_SPINNER: 1
         shell: bash
       - uses: actions/upload-artifact@v4
         with:
           include-hidden-files: true
-          name: coverage_linux-fips-3.8-${{ matrix.cloud-provider }}
+          name: coverage_linux-fips-3.9-${{ matrix.cloud-provider }}
           path: |
             .coverage
             coverage.xml
@@ -217,7 +217,7 @@ jobs:
         os:
           - image_name: macos-latest
             download_name: macos  # it includes doctest
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         cloud-provider: [aws]
     steps:
       - name: Checkout Code
@@ -289,7 +289,7 @@ jobs:
         os:
           - image_name: macos-latest
             download_name: macos
-        python-version: ["3.8"]
+        python-version: ["3.9"]
         cloud-provider: [aws]
     steps:
       - name: Checkout Code
@@ -352,7 +352,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest, ubuntu-latest]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         cloud-provider: [aws]
     steps:
       - name: Checkout Code
@@ -482,7 +482,7 @@ jobs:
         os:
           - image_name: macos-latest
             download_name: macos  # it includes doctest
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         cloud-provider: [aws]
     steps:
       - name: Checkout Code
diff --git a/.github/workflows/precommit.yml b/.github/workflows/precommit.yml
@@ -230,12 +230,12 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest, ubuntu-latest]
-        python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
+        python-version: ["3.9", "3.10", "3.11", "3.12" ]
         cloud-provider: [aws]
         exclude:
           # only run each version on one os
           # daily-precommit does full matrix
-          # macos runs 3.8 and 3.9
+          # macos runs 3.10
           - os: macos-latest
             python-version: "3.12"
           - os: macos-latest
@@ -247,17 +247,13 @@ jobs:
             python-version: "3.12"
           - os: windows-latest
             python-version: "3.10"
-          - os: windows-latest
-            python-version: "3.8"
           # ubuntu runs 3.12
           - os: ubuntu-latest
             python-version: "3.11"
           - os: ubuntu-latest
             python-version: "3.10"
           - os: ubuntu-latest
             python-version: "3.9"
-          - os: ubuntu-latest
-            python-version: "3.8"
     steps:
       - name: Checkout Code
         uses: actions/checkout@v4
@@ -315,6 +311,7 @@ jobs:
             .tox/coverage.xml
 
   test-ast-encoding:
+    if: false  # SNOW-2005312: re-enable after addressing SNOW-1763185
     name: Test AST Encoding py-${{ matrix.os }}-${{ matrix.python-version }}
     needs: build
     runs-on: ${{ matrix.os }}
@@ -324,7 +321,7 @@ jobs:
         os: [macos-latest, windows-latest, ubuntu-latest]
         # TODO SNOW-1763185 use py39 by default
         # Protobuf encoding differs per python version, use 3.8 by default.
-        python-version: [ "3.8"]
+        python-version: [ "3.8" ]
         cloud-provider: [aws]
         protobuf-version: ["3.20.1"]
     steps:
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Release History
 
+## 1.31.0 (YYYY-MM-DD)
+
+### Snowpark Python API Updates
+
+#### Deprecations
+
+- Deprecated support for Python3.8.
+
 ## 1.30.0 (2024-03-27)
 
 ### Snowpark Python API Updates
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -34,7 +34,7 @@ cd snowpark-python
 #### Install the library in edit mode and install its dependencies
 
 - Create a new Python virtual environment with any Python version that we support.
-  - The Snowpark Python API supports **Python 3.8, Python 3.9, Python 3.10, and Python 3.11**.
+  - The Snowpark Python API supports **Python 3.9, Python 3.10, Python 3.11 and Python 3.12**.
   - The Snowpark pandas API supports **Python 3.9, Python 3.10, and Python 3.11**. Additionally, Snowpark pandas requires **Modin 0.30.1** and **pandas 2.2.x**.
 
     ```bash
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ If you don't have a Snowflake account yet, you can [sign up for a 30-day free tr
 
 ### Create a Python virtual environment
 You can use [miniconda][miniconda], [anaconda][anaconda], or [virtualenv][virtualenv]
-to create a Python 3.8, 3.9, 3.10 or 3.11 virtual environment.
+to create a Python 3.9, 3.10, 3.11 or 3.12 virtual environment.
 
 For Snowpark pandas, only Python 3.9, 3.10, or 3.11 is supported.
 
diff --git a/ci/docker/snowpark_test_fips/Dockerfile b/ci/docker/snowpark_test_fips/Dockerfile
@@ -19,7 +19,7 @@ RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
 RUN yum clean all && \
     yum groupinstall -y "Development Tools" && \
     yum install -y redhat-rpm-config gcc libffi-devel wget && \
-    yum install -y perl-IPC-Cmd perl-Digest-SHA perl-Test-Simple perl-Pod-Html python38 python38-devel && \
+    yum install -y perl-IPC-Cmd perl-Digest-SHA perl-Test-Simple perl-Pod-Html python39 python39-devel && \
     yum clean all && \
     rm -rf /var/cache/yum
 
diff --git a/ci/test_fips.sh b/ci/test_fips.sh
@@ -8,7 +8,7 @@ THIS_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 SNOWPARK_DIR="$( dirname "${THIS_DIR}")"
 SNOWPARK_WHL="$(ls $SNOWPARK_DIR/dist/*.whl | sort -r | head -n 1)"
 
-python3.8 -m venv fips_env
+python3.9 -m venv fips_env
 source fips_env/bin/activate
 export PATH=/usr/local/bin:$PATH
 export LD_LIBRARY_PATH=/usr/local/lib64/:/usr/local/lib/:$LD_LIBRARY_PATH
diff --git a/scripts/jenkins_regress.sh b/scripts/jenkins_regress.sh
@@ -20,5 +20,5 @@ gpg --quiet --batch --yes --decrypt --passphrase="$GPG_KEY" --output "tests/para
 # Install protoc
 pip install protoc-wheel-0==21.1 mypy-protobuf
 
-# Run linter, Python 3.8 test and code coverage jobs
+# Run linter, Python test and code coverage jobs
 exit_code_decorator "python -m tox -c $WORKING_DIR" -e notdoctest
diff --git a/scripts/tox_install_cmd.sh b/scripts/tox_install_cmd.sh
@@ -15,6 +15,7 @@ echo "${pip_options[*]}"
 
 # Default to empty, to ensure snowflake_path variable is defined.
 snowflake_path=${snowflake_path:-""}
+python_version=$(python -c 'import sys; print(f"cp{sys.version_info.major}{sys.version_info.minor}")')
 
 if [[ -z "${snowflake_path}" ]]; then
   echo "Using Python Connector from PyPI"
@@ -23,6 +24,6 @@ else
   echo "Installing locally built Python Connector"
   echo "Python Connector path: ${snowflake_path}"
   ls -al ${snowflake_path}
-  python -m pip install ${snowflake_path}/snowflake_connector_python*cp38*.whl
+  python -m pip install ${snowflake_path}/snowflake_connector_python*${python_version}*.whl
   python -m pip install -U ${pip_options[@]}
 fi
diff --git a/setup.py b/setup.py
@@ -30,10 +30,10 @@
     "python-dateutil",  # Snowpark IR
     "tzlocal",  # Snowpark IR
 ]
-REQUIRED_PYTHON_VERSION = ">=3.8, <3.13"
+REQUIRED_PYTHON_VERSION = ">=3.9, <3.13"
 
 if os.getenv("SNOWFLAKE_IS_PYTHON_RUNTIME_TEST", False):
-    REQUIRED_PYTHON_VERSION = ">=3.8"
+    REQUIRED_PYTHON_VERSION = ">=3.9"
 
 PANDAS_REQUIREMENTS = [
     f"snowflake-connector-python[pandas]{CONNECTOR_DEPENDENCY_VERSION}",
@@ -232,7 +232,6 @@ def run(self):
         "Operating System :: OS Independent",
         "Programming Language :: SQL",
         "Programming Language :: Python :: 3 :: Only",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
diff --git a/src/conftest.py b/src/conftest.py
@@ -41,27 +41,6 @@ def pytest_runtest_makereport(item, call):
     return tr
 
 
-# These tests require python packages that are no longer built for python 3.8
-PYTHON_38_SKIPS = {
-    "snowpark.session.Session.replicate_local_environment",
-    "snowpark.session.Session.table_function",
-}
-
-DocTestFinder = doctest.DocTestFinder
-
-
-class CustomDocTestFinder(DocTestFinder):
-    def _find(self, tests, obj, name, module, source_lines, globs, seen):
-        if name in PYTHON_38_SKIPS and sys.version_info < (3, 9):
-            return
-        return DocTestFinder._find(
-            self, tests, obj, name, module, source_lines, globs, seen
-        )
-
-
-doctest.DocTestFinder = CustomDocTestFinder
-
-
 # scope is module so that we ensure we delete the session before
 # moving onto running the tests in the tests dir. Having only one
 # session is important to certain UDF tests to pass , since they
diff --git a/tests/README.md b/tests/README.md
@@ -55,8 +55,8 @@ your web browser. This will be located in `<project_dir>/.tox/htmlcov`
 
 To just run the all Snowpark tests, run the following command:
 ```bash
-# Must have Python 3.8 for the tests to run
-python -m tox -e py38
+# Must have Python 3.9 for the tests to run
+python -m tox -e py39
 ```
 ### Running doctests
 
diff --git a/tests/integ/test_packaging.py b/tests/integ/test_packaging.py
@@ -29,11 +29,6 @@
 )
 
 
-if sys.version_info >= (3, 9):
-    runtime_39_or_above = True
-else:
-    runtime_39_or_above = False
-
 try:
     import dateutil
 
@@ -474,9 +469,6 @@ def test_add_unsupported_requirements_twice_should_not_fail_for_same_requirement
     IS_IN_STORED_PROC,
     reason="Subprocess calls are not allowed within stored procedures.",
 )
-@pytest.mark.skipif(
-    not runtime_39_or_above, reason="arch is not available on python 3.8"
-)
 def test_add_packages_should_fail_if_dependency_package_already_added(session):
     session.custom_package_usage_config = {"enabled": True, "force_push": True}
     udf_name = Utils.random_name_for_temp_object(TempObjectType.FUNCTION)
@@ -685,7 +677,7 @@ def test_add_requirements_yaml(session, resources_path):
         "seaborn",
         "scipy",
     }
-    assert session._runtime_version_from_requirement == "3.8"
+    assert session._runtime_version_from_requirement == "3.9"
 
     udf_name = Utils.random_name_for_temp_object(TempObjectType.FUNCTION)
     system_version = f"{sys.version_info[0]}.{sys.version_info[1]}"
diff --git a/tests/integ/test_stored_procedure_profiler.py b/tests/integ/test_stored_procedure_profiler.py
@@ -171,7 +171,7 @@ def test_set_incorrect_active_profiler(
         """WITH myProcedure AS PROCEDURE ()
       RETURNS TABLE ( )
       LANGUAGE PYTHON
-      RUNTIME_VERSION = '3.8'
+      RUNTIME_VERSION = '3.9'
       PACKAGES = ( 'snowflake-snowpark-python==1.2.0', 'pandas==1.3.3' )
       IMPORTS = ( '@my_stage/file1.py', '@my_stage/file2.py' )
       HANDLER = 'my_function'
diff --git a/tests/resources/test_environment.yml b/tests/resources/test_environment.yml
@@ -5,7 +5,7 @@ channels:  # List of Conda channels to use for package installation
   - defaults
 
 dependencies:  # List of packages and versions to include in the environment
-  - python=3.8.5  # Python version
+  - python=3.9.21  # Python version
   - numpy=1.24.3
   - pandas
   - scikit-learn=0.24.2
