Skip to content

Commit 2165a18

Browse files
authored
NO-SNOW: Further reduce number of tests run in precommit (#3525)
1 parent d33c3d7 commit 2165a18

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

.github/workflows/precommit.yml

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,16 @@ jobs:
108108
- cloud-provider: azure
109109
python-version: "3.12"
110110
os: ubuntu-latest-64-cores
111-
# run py 3.12 tests on aws across all operating systems
111+
# run py 3.12 tests on aws on ubuntu and macos
112112
- python-version: "3.12"
113113
cloud-provider: aws
114114
os: ubuntu-latest-64-cores
115115
- python-version: "3.12"
116116
cloud-provider: aws
117117
os: macos-latest
118+
# run py 3.12 tests on gcp on windows to help take load off aws runners
118119
- python-version: "3.12"
119-
cloud-provider: aws
120+
cloud-provider: gcp
120121
os: windows-latest-64-cores
121122
steps:
122123
- name: Checkout Code
@@ -458,29 +459,25 @@ jobs:
458459
matrix:
459460
# matrix is empty for pre-commit, tests are only added
460461
# through the include directive
462+
# We split Python version and OS differences across the different clouds to make sure
463+
# the actions runners do not get overwhelmed.
464+
# When support for a new Python version is added in the future, avoid adding a new task
465+
# --just replace the version on an old one, and let the daily job handle full python
466+
# version/cloud/OS permutation coverage.
461467
include:
462-
# only run py3.9 tests on ubuntu+aws to isolate 3.9 failures
468+
# The steps below are configured to run only doctests for macos-3.12-aws
463469
- python-version: "3.9"
464-
os: ubuntu-latest-64-cores
470+
os: macos-latest
465471
cloud-provider: aws
466-
# only run gcp tests with latest python and ubuntu
467472
- cloud-provider: gcp
468-
python-version: "3.12"
469-
os: ubuntu-latest-64-cores
470-
# only run azure tests with latest python and ubuntu
473+
python-version: "3.11"
474+
os: windows-latest-64-cores
471475
- cloud-provider: azure
472-
python-version: "3.12"
476+
python-version: "3.10"
473477
os: ubuntu-latest-64-cores
474-
# run py 3.12 tests on aws across all operating systems
475478
- python-version: "3.12"
476479
cloud-provider: aws
477480
os: ubuntu-latest-64-cores
478-
- python-version: "3.12"
479-
cloud-provider: aws
480-
os: macos-latest
481-
- python-version: "3.12"
482-
cloud-provider: aws
483-
os: windows-latest-64-cores
484481
steps:
485482
- name: Checkout Code
486483
uses: actions/checkout@v4

0 commit comments

Comments
 (0)