NO-SNOW: fix type check before AST in sort() (#3982)

Author: sfc-gh-mayliu

src/snowflake/snowpark/dataframe.py

@@ -2153,7 +2153,8 @@ def sort(
             -------------
             <BLANKLINE>
 
-            >>> df.sort(ascending=False).show()
+            >>> # Sort by all columns (ORDER BY ALL) - no columns specified
+            >>> df.sort([], ascending=False).show()
             -------------
             |"A"  |"B"  |
             -------------
@@ -2182,7 +2183,10 @@ def sort(
             The aliases ``order_by()`` and ``orderBy()`` have the same behavior.
         """
 
-        is_order_by_all = not cols
+        # This code performs additional type checks, run first.
+        exprs = self._convert_cols_to_exprs("sort()", *cols)
+        is_order_by_all = not cols or not exprs
+
         if (
             is_order_by_all
             and ascending is not None
@@ -2230,10 +2234,6 @@ def sort(
             order = Ascending() if bool(asc_value) else Descending()
             sort_exprs = [SortByAllOrder(order)]
         else:
-            exprs = self._convert_cols_to_exprs("sort()", *cols)
-            if not exprs:
-                raise ValueError("sort() needs at least one sort expression.")
-
             orders = []
             if ascending is not None:
                 if isinstance(ascending, (list, tuple)):

tests/integ/scala/test_dataframe_suite.py

@@ -1219,11 +1219,6 @@ def test_sort(session):
         for i in range(len(sorted_rows) - 1)
     ]
 
-    # Negative test: sort() needs at least one sort expression
-    with pytest.raises(ValueError) as ex_info:
-        df.sort([])
-    assert "sort() needs at least one sort expression" in ex_info.value.args[0]
-
 
 def test_select(session):
     df = session.create_dataframe([(1, "a", 10), (2, "b", 20), (3, "c", 30)]).to_df(

tests/integ/test_simplifier_suite.py

@@ -1807,6 +1807,10 @@ def test_sort_by_all_sql_simplifier(session, use_simplified_query_generation):
         df2 = df.select("a", "b", "c").sort(ascending=False)
         assert "ORDER BY" and "ALL" in df2.queries["queries"][0].upper()
         Utils.check_answer(df2, [Row(3, "c", 30), Row(2, "b", 20), Row(1, "a", 10)])
+
+        df3 = df.select("a", "b").orderBy([], ascending=True)
+        assert "ORDER BY" and "ALL" in df3.queries["queries"][0].upper()
+        Utils.check_answer(df3, df1)
     finally:
         session.conf.set("use_simplified_query_generation", original)