Skip to content

Commit 3b25773

Browse files
committed
minor comments
1 parent 01c64e3 commit 3b25773

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/snowflake/snowpark/_internal/analyzer/select_statement.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2250,6 +2250,7 @@ def derive_column_states_from_subquery(
22502250
if from_c_state and from_c_state.change_state != ColumnChangeState.DROPPED:
22512251
# review later. should use parse_column_name
22522252
# SNOW-2895675: Always treat Aliases as "changed", even if it is an identity.
2253+
# The fact this check is needed may be a bug in column state analysis, and we should revisit it later.
22532254
if c_name != result_name or isinstance(c, Alias):
22542255
column_states[quoted_c_name] = ColumnState(
22552256
quoted_c_name,

src/snowflake/snowpark/dataframe.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,8 @@ def _disambiguate(
346346
# Optimization: No column name conflicts, so we can skip aliasing and the select() wrapping.
347347
# But we still need to populate expr_to_alias for column lineage tracking,
348348
# so that df["column_name"] can resolve correctly after the join.
349-
# This is identified by the test case test_name_alias_on_multiple_join.
349+
# This is identified by the test case
350+
# tests/integ/scala/test_dataframe_join_suite.py::test_name_alias_on_multiple_join.
350351
_populate_expr_to_alias(lhs)
351352
_populate_expr_to_alias(rhs)
352353
return lhs, rhs

0 commit comments

Comments
 (0)