move to _integraltype

Author: sfc-gh-yuwang

src/snowflake/snowpark/_internal/type_utils.py

@@ -307,7 +307,7 @@ def convert_sf_to_sp_type(
     if column_type_name == "REAL":
         return DoubleType()
     if (column_type_name == "FIXED" or column_type_name == "NUMBER") and scale == 0:
-        return LongType(precision=precision, scale=scale)
+        return LongType(precision=precision)
     raise NotImplementedError(
         "Unsupported type: {}, precision: {}, scale: {}".format(
             column_type_name, precision, scale

src/snowflake/snowpark/types.py

@@ -169,20 +169,7 @@ def _fill_ast(self, ast: proto.DataType) -> None:
 
 
 class _NumericType(_AtomicType):
-    def __init__(self, **kwargs) -> None:
-        self._precision = kwargs.get("precision", None)
-        self._scale = kwargs.get("scale", None)
-
-    def __eq__(self, other):
-        def filtered(d: dict) -> dict:
-            return {k: v for k, v in d.items() if k not in ("_precision", "_scale")}
-
-        return isinstance(other, self.__class__) and filtered(
-            self.__dict__
-        ) == filtered(other.__dict__)
-
-    def __hash__(self):
-        return hash(repr(self))
+    pass
 
 
 class TimestampTimeZone(Enum):
@@ -383,7 +370,19 @@ def _fill_ast(self, ast: proto.DataType) -> None:
 
 # Numeric types
 class _IntegralType(_NumericType):
-    pass
+    def __init__(self, **kwargs) -> None:
+        self._precision = kwargs.get("precision", None)
+
+    def __eq__(self, other):
+        def filtered(d: dict) -> dict:
+            return {k: v for k, v in d.items() if k != "_precision"}
+
+        return isinstance(other, self.__class__) and filtered(
+            self.__dict__
+        ) == filtered(other.__dict__)
+
+    def __hash__(self):
+        return hash(repr(self))
 
 
 class _FractionalType(_NumericType):

tests/integ/test_datatypes.py

@@ -433,7 +433,7 @@ def test_numeric_type_store_precision_and_scale(session, massive_number, precisi
         result = session.sql(f"select * from {table_name}")
         datatype = result.schema.fields[0].datatype
         assert isinstance(datatype, LongType)
-        assert datatype._precision == 38 and datatype._scale == 0
+        assert datatype._precision == 38
     finally:
         session.sql(f"drop table {table_name}").collect()
 
@@ -484,7 +484,7 @@ def write_csv(data):
         df1 = constrained_reader.csv(f"@{stage_name}/")
         datatype = df1.schema.fields[0].datatype
         assert isinstance(datatype, LongType)
-        assert datatype._precision == 38 and datatype._scale == 0
+        assert datatype._precision == 38
 
     finally:
         Utils.drop_stage(session, stage_name)