Skip to content

Commit 4f3d174

Browse files
committed
private
1 parent 1bbd89e commit 4f3d174

File tree

6 files changed

+36
-36
lines changed

6 files changed

+36
-36
lines changed

src/snowflake/snowpark/_internal/udf_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,22 +1228,22 @@ def resolve_imports_and_packages(
12281228
bool,
12291229
]:
12301230
from snowflake.snowpark.session import (
1231-
ANACONDA_SHARED_REPOSITORY,
1232-
DEFAULT_ARTIFACT_REPOSITORY,
1231+
_ANACONDA_SHARED_REPOSITORY,
1232+
_DEFAULT_ARTIFACT_REPOSITORY,
12331233
)
12341234

12351235
if artifact_repository is None:
12361236
artifact_repository = (
12371237
session._get_default_artifact_repository()
12381238
if session
1239-
else DEFAULT_ARTIFACT_REPOSITORY
1239+
else _DEFAULT_ARTIFACT_REPOSITORY
12401240
)
12411241

12421242
existing_packages_dict = (
12431243
session._artifact_repository_packages[artifact_repository] if session else {}
12441244
)
12451245

1246-
if artifact_repository != ANACONDA_SHARED_REPOSITORY:
1246+
if artifact_repository != _ANACONDA_SHARED_REPOSITORY:
12471247
# Non-conda artifact repository - skip conda-based package resolution
12481248
resolved_packages = []
12491249
if not packages and session:

src/snowflake/snowpark/session.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,9 +322,9 @@
322322
WRITE_ARROW_CHUNK_SIZE: int = 100000 if is_in_stored_procedure() else None
323323

324324
# The fully qualified name of the Anaconda shared repository (conda channel).
325-
ANACONDA_SHARED_REPOSITORY = "snowflake.snowpark.anaconda_shared_repository"
325+
_ANACONDA_SHARED_REPOSITORY = "snowflake.snowpark.anaconda_shared_repository"
326326
# In case of failures or the current default artifact repository is unset, we fallback to this
327-
DEFAULT_ARTIFACT_REPOSITORY = ANACONDA_SHARED_REPOSITORY
327+
_DEFAULT_ARTIFACT_REPOSITORY = _ANACONDA_SHARED_REPOSITORY
328328

329329

330330
def _get_active_session() -> "Session":
@@ -2144,7 +2144,7 @@ def _resolve_packages(
21442144
package_dict = self._parse_packages(packages)
21452145
if (
21462146
isinstance(self._conn, MockServerConnection)
2147-
or artifact_repository != ANACONDA_SHARED_REPOSITORY
2147+
or artifact_repository != _ANACONDA_SHARED_REPOSITORY
21482148
):
21492149
# in local testing or non-conda, we don't resolve the packages, we just return what is added
21502150
errors = []
@@ -2405,7 +2405,7 @@ def _get_default_artifact_repository(self) -> str:
24052405
"""
24062406
with self._package_lock:
24072407
if isinstance(self._conn, MockServerConnection):
2408-
return DEFAULT_ARTIFACT_REPOSITORY
2408+
return _DEFAULT_ARTIFACT_REPOSITORY
24092409

24102410
cache_key = (self.get_current_database(), self.get_current_schema())
24112411

@@ -2421,12 +2421,12 @@ def _get_default_artifact_repository(self) -> str:
24212421
f"SELECT SYSTEM$GET_DEFAULT_PYTHON_ARTIFACT_REPOSITORY('{python_version}')"
24222422
)
24232423
value = result[0][0] if result else None
2424-
resolved = value or DEFAULT_ARTIFACT_REPOSITORY
2424+
resolved = value or _DEFAULT_ARTIFACT_REPOSITORY
24252425
except Exception as e:
24262426
_logger.warning(
2427-
f"Error getting default artifact repository: {e}. Using fallback: {DEFAULT_ARTIFACT_REPOSITORY}."
2427+
f"Error getting default artifact repository: {e}. Using fallback: {_DEFAULT_ARTIFACT_REPOSITORY}."
24282428
)
2429-
resolved = DEFAULT_ARTIFACT_REPOSITORY
2429+
resolved = _DEFAULT_ARTIFACT_REPOSITORY
24302430

24312431
self._default_artifact_repository_cache = (cache_key, resolved)
24322432
return resolved

src/snowflake/snowpark/stored_procedure.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -941,12 +941,12 @@ def _do_register_sp(
941941

942942
effective_artifact_repository = artifact_repository
943943
if effective_artifact_repository is None:
944-
from snowflake.snowpark.session import DEFAULT_ARTIFACT_REPOSITORY
944+
from snowflake.snowpark.session import _DEFAULT_ARTIFACT_REPOSITORY
945945

946946
effective_artifact_repository = (
947947
self._session._get_default_artifact_repository()
948948
if self._session
949-
else DEFAULT_ARTIFACT_REPOSITORY
949+
else _DEFAULT_ARTIFACT_REPOSITORY
950950
)
951951

952952
# Add in snowflake-snowpark-python if it is not already in the package list.

tests/integ/test_packaging.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
get_signature,
2121
)
2222
from snowflake.snowpark.functions import call_udf, col, count_distinct, sproc, udf
23-
from snowflake.snowpark.session import ANACONDA_SHARED_REPOSITORY
23+
from snowflake.snowpark.session import _ANACONDA_SHARED_REPOSITORY
2424
from snowflake.snowpark.types import DateType, StringType
2525
from tests.utils import IS_IN_STORED_PROC, TempObjectType, TestFiles, Utils
2626

@@ -271,7 +271,7 @@ def extract_major_minor_patch(version_string):
271271

272272
resolved_packages = session._resolve_packages(
273273
[numpy, pandas, dateutil],
274-
ANACONDA_SHARED_REPOSITORY,
274+
_ANACONDA_SHARED_REPOSITORY,
275275
{},
276276
validate_package=False,
277277
)
@@ -1208,13 +1208,13 @@ def test_replicate_local_environment(session):
12081208
[
12091209
package.startswith("cloudpickle")
12101210
for package in session._artifact_repository_packages[
1211-
ANACONDA_SHARED_REPOSITORY
1211+
_ANACONDA_SHARED_REPOSITORY
12121212
]
12131213
]
12141214
)
12151215

12161216
def naive_add_packages(self, packages):
1217-
self._artifact_repository_packages[ANACONDA_SHARED_REPOSITORY] = packages
1217+
self._artifact_repository_packages[_ANACONDA_SHARED_REPOSITORY] = packages
12181218

12191219
with patch.object(session, "_is_anaconda_terms_acknowledged", lambda: True):
12201220
with patch.object(Session, "add_packages", new=naive_add_packages):
@@ -1232,7 +1232,7 @@ def naive_add_packages(self, packages):
12321232
[
12331233
package.startswith("cloudpickle==")
12341234
for package in session._artifact_repository_packages[
1235-
ANACONDA_SHARED_REPOSITORY
1235+
_ANACONDA_SHARED_REPOSITORY
12361236
]
12371237
]
12381238
)
@@ -1241,7 +1241,7 @@ def naive_add_packages(self, packages):
12411241
[
12421242
package.startswith(default_package)
12431243
for package in session._artifact_repository_packages[
1244-
ANACONDA_SHARED_REPOSITORY
1244+
_ANACONDA_SHARED_REPOSITORY
12451245
]
12461246
]
12471247
)
@@ -1266,7 +1266,7 @@ def naive_add_packages(self, packages):
12661266
[
12671267
package == "cloudpickle"
12681268
for package in session._artifact_repository_packages[
1269-
ANACONDA_SHARED_REPOSITORY
1269+
_ANACONDA_SHARED_REPOSITORY
12701270
]
12711271
]
12721272
)
@@ -1275,7 +1275,7 @@ def naive_add_packages(self, packages):
12751275
[
12761276
package.startswith(default_package)
12771277
for package in session._artifact_repository_packages[
1278-
ANACONDA_SHARED_REPOSITORY
1278+
_ANACONDA_SHARED_REPOSITORY
12791279
]
12801280
]
12811281
)
@@ -1284,7 +1284,7 @@ def naive_add_packages(self, packages):
12841284
[
12851285
package.startswith(ignored_package)
12861286
for package in session._artifact_repository_packages[
1287-
ANACONDA_SHARED_REPOSITORY
1287+
_ANACONDA_SHARED_REPOSITORY
12881288
]
12891289
]
12901290
)

tests/unit/test_session.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
)
3131
from snowflake.snowpark.session import (
3232
_PYTHON_SNOWPARK_USE_SCOPED_TEMP_OBJECTS_STRING,
33-
ANACONDA_SHARED_REPOSITORY,
33+
_ANACONDA_SHARED_REPOSITORY,
3434
)
3535
from snowflake.snowpark.types import StructField, StructType
3636

@@ -215,7 +215,7 @@ def mock_get_information_schema_packages(table_name: str, _emit_ast: bool = True
215215

216216
session._resolve_packages(
217217
["random_package_name"],
218-
ANACONDA_SHARED_REPOSITORY,
218+
_ANACONDA_SHARED_REPOSITORY,
219219
{},
220220
validate_package=True,
221221
include_pandas=False,
@@ -250,7 +250,7 @@ def run_query(sql: str):
250250
):
251251
session._resolve_packages(
252252
["random_package_name"],
253-
ANACONDA_SHARED_REPOSITORY,
253+
_ANACONDA_SHARED_REPOSITORY,
254254
{},
255255
validate_package=True,
256256
include_pandas=False,
@@ -275,7 +275,7 @@ def mock_get_information_schema_packages(table_name: str, _emit_ast: bool = True
275275

276276
resolved_packages = session._resolve_packages(
277277
["random_package_name"],
278-
ANACONDA_SHARED_REPOSITORY,
278+
_ANACONDA_SHARED_REPOSITORY,
279279
existing_packages,
280280
validate_package=True,
281281
include_pandas=False,
@@ -307,7 +307,7 @@ def mock_get_information_schema_packages(table_name: str, _emit_ast: bool = True
307307
):
308308
session._resolve_packages(
309309
["snowflake-snowpark-python"],
310-
ANACONDA_SHARED_REPOSITORY,
310+
_ANACONDA_SHARED_REPOSITORY,
311311
{},
312312
validate_package=True,
313313
include_pandas=False,
@@ -752,7 +752,7 @@ def test_get_default_artifact_repository():
752752
session, "get_current_schema", return_value="SCHEMA2"
753753
):
754754
result = session._get_default_artifact_repository()
755-
assert result == ANACONDA_SHARED_REPOSITORY
755+
assert result == _ANACONDA_SHARED_REPOSITORY
756756

757757
assert mocked_run_query.call_count == 1
758758

@@ -764,6 +764,6 @@ def test_get_default_artifact_repository():
764764
session, "get_current_schema", return_value="SCHEMA1"
765765
):
766766
result = session._get_default_artifact_repository()
767-
assert result == ANACONDA_SHARED_REPOSITORY
767+
assert result == _ANACONDA_SHARED_REPOSITORY
768768

769769
assert mocked_run_query.call_count == 1

tests/unit/test_udf_utils.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
resolve_packages_in_client_side_sandbox,
2727
)
2828
from snowflake.snowpark._internal.utils import TempObjectType
29-
from snowflake.snowpark.session import ANACONDA_SHARED_REPOSITORY
29+
from snowflake.snowpark.session import _ANACONDA_SHARED_REPOSITORY
3030
from snowflake.snowpark.types import StringType
3131
from snowflake.snowpark.version import VERSION
3232

@@ -227,7 +227,7 @@ def test_resolve_imports_and_packages_imports_as_str(tmp_path_factory):
227227
def test_add_snowpark_package_to_sproc_packages_add_package(packages):
228228
old_packages_length = len(packages) if packages else 0
229229
result = add_snowpark_package_to_sproc_packages(
230-
session=None, packages=packages, artifact_repository=ANACONDA_SHARED_REPOSITORY
230+
session=None, packages=packages, artifact_repository=_ANACONDA_SHARED_REPOSITORY
231231
)
232232

233233
major, minor, patch = VERSION
@@ -245,7 +245,7 @@ def test_add_snowpark_package_to_sproc_packages_does_not_replace_package():
245245
"snowflake-snowpark-python==1.12.0",
246246
]
247247
result = add_snowpark_package_to_sproc_packages(
248-
session=None, packages=packages, artifact_repository=ANACONDA_SHARED_REPOSITORY
248+
session=None, packages=packages, artifact_repository=_ANACONDA_SHARED_REPOSITORY
249249
)
250250

251251
assert len(result) == len(packages)
@@ -255,15 +255,15 @@ def test_add_snowpark_package_to_sproc_packages_does_not_replace_package():
255255
def test_add_snowpark_package_to_sproc_packages_to_session():
256256
fake_session = mock.create_autospec(Session)
257257
fake_session._artifact_repository_packages = defaultdict(dict)
258-
fake_session._artifact_repository_packages[ANACONDA_SHARED_REPOSITORY] = {
258+
fake_session._artifact_repository_packages[_ANACONDA_SHARED_REPOSITORY] = {
259259
"random_package_one": "random_package_one",
260260
"random_package_two": "random_package_two",
261261
}
262262
fake_session._package_lock = threading.RLock()
263263
result = add_snowpark_package_to_sproc_packages(
264264
session=fake_session,
265265
packages=None,
266-
artifact_repository=ANACONDA_SHARED_REPOSITORY,
266+
artifact_repository=_ANACONDA_SHARED_REPOSITORY,
267267
)
268268

269269
major, minor, patch = VERSION
@@ -272,13 +272,13 @@ def test_add_snowpark_package_to_sproc_packages_to_session():
272272
assert len(result) == 3
273273
assert final_name in result
274274

275-
fake_session._artifact_repository_packages[ANACONDA_SHARED_REPOSITORY][
275+
fake_session._artifact_repository_packages[_ANACONDA_SHARED_REPOSITORY][
276276
"snowflake-snowpark-python"
277277
] = "snowflake-snowpark-python==1.12.0"
278278
result = add_snowpark_package_to_sproc_packages(
279279
session=fake_session,
280280
packages=None,
281-
artifact_repository=ANACONDA_SHARED_REPOSITORY,
281+
artifact_repository=_ANACONDA_SHARED_REPOSITORY,
282282
)
283283
assert result is None
284284

0 commit comments

Comments
 (0)