NO-SNOW: Disable Stored Proc telemetry by default (#3701)

Author: sfc-gh-aalam

src/snowflake/snowpark/_internal/telemetry.py

@@ -482,19 +482,17 @@ def __init__(self, conn: SnowflakeConnection) -> None:
 
         # Initializing telemetry client for stored procedures
         # In stored procs, we can't import this package at the top level, so we need to do it here
-        internal_metrics_available = None
-        if is_in_stored_procedure():
-            try:
-                from _snowflake import internal_metrics
-
-                internal_metrics_available = True
-            except ImportError:
-                internal_metrics_available = False
-        self.stored_proc_meter = (
-            internal_metrics.get_meter("snowpark-python-client")
-            if internal_metrics_available
-            else None
-        )
+        # internal_metrics_available = None
+        # if is_in_stored_procedure():
+        #     try:
+        #         from _snowflake import internal_metrics
+
+        #         internal_metrics_available = True
+        #     except ImportError:
+        #         internal_metrics_available = False
+
+        # SNOW-2321754: Enable this once we have re-factored the telemetry to use otel metrics
+        self.stored_proc_meter = None
         # We periodically clean out the stored procedure meter of unused gauges
         self.clean_up_stored_proc_meter_interval = 1000
 

src/snowflake/snowpark/session.py

@@ -4149,7 +4149,7 @@ def telemetry_enabled(self, value):
         # Set both in-band and out-of-band telemetry to True/False
         if value:
             self._conn._telemetry_client._enabled = True
-            if is_in_stored_procedure() and not self._stored_proc_telemetry_enabled:
+            if is_in_stored_procedure() and not self._internal_telemetry_enabled:
                 _logger.debug(
                     "Client side parameter ENABLE_SNOWPARK_FIRST_PARTY_TELEMETRY is set to False, telemetry could not be enabled"
                 )

tests/unit/test_stored_proc_telemetry.py

@@ -110,7 +110,7 @@ def test_internal_telemetry_disabled(mock_logger, mock_is_in_stored_proc):
     """Test that Session logs debug message when telemetry is enabled but stored proc telemetry is disabled"""
     mock_is_in_stored_proc.return_value = True
     mock_session = MagicMock(spec=Session)
-    mock_session._stored_proc_telemetry_enabled = False
+    mock_session._internal_telemetry_enabled = False
     mock_session._conn = MagicMock()
     mock_session._conn._conn = MagicMock()
     mock_session._conn._telemetry_client = MagicMock()