address comments

Author: sfc-gh-yuwang

CHANGELOG.md

@@ -24,7 +24,6 @@
 #### Bug Fixes
 
 - Fixed a bug in local testing mode that caused a column to contain None when it should contain 0
-- Fixed a bug in StructField.from_json that prevented TimestampTypes with tzinfo from being parsed correctly.
 - Fixed a bug in `StructField.from_json` that prevented TimestampTypes with tzinfo from being parsed correctly.
 - Fixed a bug in function `date_format` that caused an error when the input column was date type or timestamp type.
 - Fixed a bug in dataframe that null value can be inserted in a non-nullable column.

src/snowflake/snowpark/_internal/analyzer/snowflake_plan_node.py

@@ -165,10 +165,11 @@ def is_contain_illegal_null_value(self) -> bool:
         rows_to_compare = min(
             ARRAY_BIND_THRESHOLD // len(self.output) + 1, len(self.data)
         )
-        for i in range(rows_to_compare):
-            for j in range(len(self.output)):
-                if self.data[i][j] is None and not self.output[j].nullable:
-                    return True
+        for j in range(len(self.output)):
+            if not self.output[j].nullable:
+                for i in range(rows_to_compare):
+                    if self.data[i][j] is None:
+                        return True
         return False
 
     @property

tests/integ/test_dataframe.py

@@ -1827,8 +1827,10 @@ def test_create_dataframe_with_schema_col_names(session):
     for field, expected_name in zip(df.schema.fields, col_names[:2] + ["_3", "_4"]):
         assert Utils.equals_ignore_case(field.name, expected_name)
 
-    # the column names provided via schema keyword will overwrite other column names
+    # specify nullable in structtype to avoid insert null value into non-nullable column
     struct_col_name = StructType([StructField(col, StringType()) for col in col_names])
+
+    # the column names provided via schema keyword will overwrite other column names
     df = session.create_dataframe(
         [{"aa": 1, "bb": 2, "cc": 3, "dd": 4}], schema=struct_col_name
     )