address comments

Author: sfc-gh-helmeleegy

src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py

@@ -9112,15 +9112,13 @@ def cumsum(
         relaxed_query_compiler = None
         if self._relaxed_query_compiler is not None:
             relaxed_query_compiler = self._relaxed_query_compiler._cumsum_internal(
-                # axis=axis,
-                # skipna=skipna,
-                *args,
+                axis=axis,
+                skipna=skipna,
                 **kwargs,
             )
         qc = self._cumsum_internal(
-            # axis=axis,
-            # skipna=skipna,
-            *args,
+            axis=axis,
+            skipna=skipna,
             **kwargs,
         )
         return self._maybe_set_relaxed_qc(qc, relaxed_query_compiler)
@@ -9172,15 +9170,13 @@ def cummin(
         relaxed_query_compiler = None
         if self._relaxed_query_compiler is not None:
             relaxed_query_compiler = self._relaxed_query_compiler._cummin_internal(
-                # axis=axis,
-                # skipna=skipna,
-                *args,
+                axis=axis,
+                skipna=skipna,
                 **kwargs,
             )
         qc = self._cummin_internal(
-            # axis=axis,
-            # skipna=skipna,
-            *args,
+            axis=axis,
+            skipna=skipna,
             **kwargs,
         )
         return self._maybe_set_relaxed_qc(qc, relaxed_query_compiler)
@@ -9232,15 +9228,13 @@ def cummax(
         relaxed_query_compiler = None
         if self._relaxed_query_compiler is not None:
             relaxed_query_compiler = self._relaxed_query_compiler._cummax_internal(
-                # axis=axis,
-                # skipna=skipna,
-                *args,
+                axis=axis,
+                skipna=skipna,
                 **kwargs,
             )
         qc = self._cummax_internal(
-            # axis=axis,
-            # skipna=skipna,
-            *args,
+            axis=axis,
+            skipna=skipna,
             **kwargs,
         )
         return self._maybe_set_relaxed_qc(qc, relaxed_query_compiler)

tests/integ/modin/test_faster_pandas.py

@@ -354,7 +354,7 @@ def test_cumulative_functions(session, func):
 
         # create snow dataframes
         df = pd.read_snowflake(table_name)
-        snow_result = df[getattr(df["B"], func)() > 0]
+        snow_result = getattr(df["B"], func)()
 
         # verify that the input dataframe has a populated relaxed query compiler
         assert df._query_compiler._relaxed_query_compiler is not None
@@ -368,10 +368,10 @@ def test_cumulative_functions(session, func):
 
         # create pandas dataframes
         native_df = df.to_pandas()
-        native_result = native_df[getattr(native_df["B"], func)() > 0]
+        native_result = getattr(native_df["B"], func)()
 
         # compare results
-        assert_frame_equal(snow_result, native_result)
+        assert_series_equal(snow_result, native_result)
 
 
 @sql_count_checker(query_count=3)