[SNOW-2138082]: Add relative path support for SnowflakeFile (#3571)

Author: sfc-gh-lju

src/snowflake/snowpark/files.py

@@ -17,7 +17,6 @@
     SEEK_CUR,
 )
 from snowflake.snowpark._internal.utils import (
-    RELATIVE_PATH_PREFIX,
     SNOWFLAKE_PATH_PREFIXES,
 )
 from typing import Sequence
@@ -82,6 +81,7 @@ class SnowflakeFile(RawIOBase):
     We provide a local implementation of SnowflakeFile to aid in local testing.
     This currently supports using read APIs on relative paths, mocked stages
     (sessions in local testing mode that aren't connected to a real stage), and Snowflake stages.
+    Scoped and Stage URLs (https://) are not yet supported.
 
     Note:
         1. All of the implementation in this file is for local testing purposes.
@@ -119,25 +119,17 @@ def __init__(
         # Attributes required for local testing functionality
         _DEFAULT_READ_BUFFER_SIZE = 32 * 1024
         self._pos = 0
-        self._is_local_file = (
-            True
-            if self._file_location.startswith((RELATIVE_PATH_PREFIX, "C:"))
-            else False
-        )
+        if self._file_location.startswith("https://"):
+            raise ValueError("Scoped and Stage URLs are not yet supported.")
+
         self._is_stage_file = (
             True
             if self._file_location.startswith(tuple(SNOWFLAKE_PATH_PREFIXES))
             else False
         )
-
-        # Validate the file location
-        if not self._is_local_file and not self._is_stage_file:
-            raise ValueError(
-                f"Invalid file location '{self._file_location}'. "
-                "File location must be a local file path or a stage file URL."
-            )
-
+        self._is_local_file = not self._is_stage_file
         self._file_size = 0
+
         if self._is_local_file and mode in _READ_MODES:
             # Buffered Reader used to support BufferedIOBase methods such as read1 and readinto1
             encoding = "utf-8" if mode == "r" else None

tests/unit/test_files.py

@@ -352,6 +352,42 @@ def sf_open(file_location: str) -> None:
         sf_open(temp_file)
 
 
+@pytest.mark.parametrize(
+    ["read_mode", "write_mode", "use_tmp_path"],
+    [("r", "w", True), ("r", "w", False), ("rb", "wb", True), ("rb", "wb", False)],
+)
+def test_read_relative_path_snowflakefile(
+    read_mode, write_mode, use_tmp_path, tmp_path
+):
+    if use_tmp_path:
+        test_msg, temp_file = Utils.write_test_msg(write_mode, tmp_path)
+    else:
+        # Write to a temp file in the current directory
+        test_msg, temp_file = Utils.write_test_msg(write_mode, "")
+    temp_file = os.path.relpath(temp_file)
+
+    def read_file(file_location: str, mode: str) -> Union[str, bytes]:
+        with SnowflakeFile.open(file_location, mode) as f:
+            return f.read()
+
+    assert read_file(temp_file, read_mode) == test_msg
+    if not use_tmp_path:
+        os.remove(temp_file)
+
+
+def test_read_scoped_url_snowflakefile():
+    scoped_url = "https://example.com/path/to/file.txt"
+
+    def read_file(file_location: str, mode: str) -> Union[str, bytes]:
+        with SnowflakeFile.open(file_location, mode) as f:
+            return f.read()
+
+    with pytest.raises(
+        ValueError, match="Scoped and Stage URLs are not yet supported."
+    ):
+        read_file(scoped_url, "r")
+
+
 @pytest.mark.parametrize(
     _STANDARD_ARGS,
     _STANDARD_ARGVALUES,