test

Author: sfc-gh-mayliu

tests/integ/scala/test_dataframe_suite.py

@@ -1219,11 +1219,6 @@ def test_sort(session):
         for i in range(len(sorted_rows) - 1)
     ]
 
-    # Negative test: sort() needs at least one sort expression
-    with pytest.raises(ValueError) as ex_info:
-        df.sort([])
-    assert "sort() needs at least one sort expression" in ex_info.value.args[0]
-
 
 def test_select(session):
     df = session.create_dataframe([(1, "a", 10), (2, "b", 20), (3, "c", 30)]).to_df(

tests/integ/test_simplifier_suite.py

@@ -1807,6 +1807,10 @@ def test_sort_by_all_sql_simplifier(session, use_simplified_query_generation):
         df2 = df.select("a", "b", "c").sort(ascending=False)
         assert "ORDER BY" and "ALL" in df2.queries["queries"][0].upper()
         Utils.check_answer(df2, [Row(3, "c", 30), Row(2, "b", 20), Row(1, "a", 10)])
+
+        df3 = df.select("a", "b").orderBy([], ascending=True)
+        assert "ORDER BY" and "ALL" in df1.queries["queries"][0].upper()
+        Utils.check_answer(df3, df1)
     finally:
         session.conf.set("use_simplified_query_generation", original)