Skip to content

Commit 9cfefe0

Browse files
authored
SNOW-2086682: Add telemetry for XML reader with row tag (#3355)
1 parent abf8680 commit 9cfefe0

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/snowflake/snowpark/_internal/utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,8 @@
200200
XML_ROW_TAG_STRING = "ROWTAG"
201201
XML_ROW_DATA_COLUMN_NAME = "ROW_DATA"
202202
XML_READER_FILE_PATH = os.path.join(os.path.dirname(__file__), "xml_reader.py")
203+
XML_READER_API_SIGNATURE = "DataFrameReader.xml[rowTag]"
204+
XML_READER_SQL_COMMENT = f"/* Python:snowflake.snowpark.{XML_READER_API_SIGNATURE} */"
203205

204206
QUERY_TAG_STRING = "QUERY_TAG"
205207
SKIP_LEVELS_TWO = (

src/snowflake/snowpark/dataframe_reader.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
XML_ROW_TAG_STRING,
5959
XML_ROW_DATA_COLUMN_NAME,
6060
XML_READER_FILE_PATH,
61+
XML_READER_API_SIGNATURE,
6162
INFER_SCHEMA_FORMAT_TYPES,
6263
SNOWFLAKE_PATH_PREFIXES,
6364
TempObjectType,
@@ -1159,7 +1160,10 @@ def _read_semi_structured_file(self, path: str, format: str) -> DataFrame:
11591160
_emit_ast=False,
11601161
)
11611162
df._reader = self
1162-
set_api_call_source(df, f"DataFrameReader.{format.lower()}")
1163+
if xml_reader_udtf:
1164+
set_api_call_source(df, XML_READER_API_SIGNATURE)
1165+
else:
1166+
set_api_call_source(df, f"DataFrameReader.{format.lower()}")
11631167
return df
11641168

11651169
@private_preview(version="1.29.0")

0 commit comments

Comments
 (0)