Commit bd46c66
authored
SNOW-1961756: Enable AST capture from Session.read.dbapi (#3134)
1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
[SNOW-1961756](https://snowflakecomputing.atlassian.net/browse/SNOW-1961756)
2. Fill out the following pre-review checklist:
- [ ] I am adding a new automated test(s) to verify correctness of my new code
- [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
- [ ] I am adding new logging messages
- [ ] I am adding a new telemetry message
- [ ] I am adding new credentials
- [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: [Thread-safe Developer Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)
3. Please describe how your code solves the related issue.
Propagate `_emit_ast=False` across all internal calls to public APIs for new `dbapi` functionality.
Importantly, we will capture uses of `session.read.dbapi` as calls to `session.table` since we only support this functionality on the client side. Attempting to capture the call would mean creating an AST entity for `session.read.dbapi` specifically just to have it show up in query history, and this does not seem valuable from an AST or server-side execution perspective.
[SNOW-1961756]: https://snowflakecomputing.atlassian.net/browse/SNOW-1961756?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ1 parent 8398094 commit bd46c66
File tree
2 files changed
+23
-16
lines changed- src/snowflake/snowpark
2 files changed
+23
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
461 | | - | |
| 461 | + | |
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| |||
1087 | 1087 | | |
1088 | 1088 | | |
1089 | 1089 | | |
| 1090 | + | |
1090 | 1091 | | |
1091 | 1092 | | |
1092 | 1093 | | |
| |||
1103 | 1104 | | |
1104 | 1105 | | |
1105 | 1106 | | |
| 1107 | + | |
1106 | 1108 | | |
1107 | 1109 | | |
1108 | 1110 | | |
| |||
1222 | 1224 | | |
1223 | 1225 | | |
1224 | 1226 | | |
1225 | | - | |
1226 | | - | |
| 1227 | + | |
| 1228 | + | |
1227 | 1229 | | |
1228 | 1230 | | |
1229 | 1231 | | |
1230 | 1232 | | |
1231 | 1233 | | |
1232 | 1234 | | |
1233 | 1235 | | |
1234 | | - | |
1235 | | - | |
| 1236 | + | |
| 1237 | + | |
1236 | 1238 | | |
1237 | 1239 | | |
1238 | 1240 | | |
| |||
1327 | 1329 | | |
1328 | 1330 | | |
1329 | 1331 | | |
1330 | | - | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
| 1336 | + | |
1331 | 1337 | | |
1332 | 1338 | | |
1333 | 1339 | | |
| |||
1476 | 1482 | | |
1477 | 1483 | | |
1478 | 1484 | | |
1479 | | - | |
1480 | | - | |
1481 | | - | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
1482 | 1490 | | |
1483 | 1491 | | |
1484 | 1492 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
337 | 337 | | |
338 | 338 | | |
339 | 339 | | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
340 | 343 | | |
341 | 344 | | |
342 | 345 | | |
| |||
466 | 469 | | |
467 | 470 | | |
468 | 471 | | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | 472 | | |
473 | 473 | | |
474 | 474 | | |
| |||
590 | 590 | | |
591 | 591 | | |
592 | 592 | | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
593 | 596 | | |
594 | 597 | | |
595 | 598 | | |
| |||
649 | 652 | | |
650 | 653 | | |
651 | 654 | | |
652 | | - | |
653 | | - | |
654 | | - | |
655 | | - | |
656 | 655 | | |
657 | 656 | | |
658 | 657 | | |
| |||
0 commit comments