Skip to content

Commit c2cbdeb

Browse files
committed
improve and fix test
1 parent f04c38b commit c2cbdeb

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

src/snowflake/snowpark/session.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1730,8 +1730,10 @@ def add_requirements(
17301730
>>> from snowflake.snowpark.functions import udf
17311731
>>> import numpy
17321732
>>> import pandas
1733+
>>> import sys
17331734
>>> # test_requirements.txt contains "numpy" and "pandas"
1734-
>>> session.add_requirements("tests/resources/test_requirements.txt")
1735+
>>> file = "test_requirements.txt" if sys.version_info < (3, 13) else "test_requirements_py313.txt"
1736+
>>> session.add_requirements(f"tests/resources/{file}")
17351737
>>> @udf
17361738
... def get_package_name_udf() -> list:
17371739
... return [numpy.__name__, pandas.__name__]
File renamed without changes.

tests/unit/scala/test_utils_suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def check_zip_files_and_close_stream(input_stream, expected_files):
350350
"resources/test_all_data_types.parquet",
351351
"resources/test_file_with_special_characters.parquet",
352352
"resources/test_requirements.txt",
353-
"resources/test_requirements_greater_than_python_3_12.txt",
353+
"resources/test_requirements_py313.txt",
354354
"resources/test_requirements_unsupported.txt",
355355
"resources/test_concat_file1.csv",
356356
"resources/test_concat_file2.csv",

tests/utils.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1633,10 +1633,12 @@ def test_pandas_udf_py_file(self):
16331633

16341634
@property
16351635
def test_requirements_file(self):
1636+
# TODO: SNOW-2389419, snowpark does not support multiple line requirements for a single package
1637+
# ideally the req file could be like:
1638+
# numpy==1.26.3; python_version<"3.13"
1639+
# numpy==2.3.1; python_version>="3.13"
16361640
if sys.version_info >= (3, 13):
1637-
return os.path.join(
1638-
self.resources_path, "test_requirements_greater_than_python_3_12.txt"
1639-
)
1641+
return os.path.join(self.resources_path, "test_requirements_py313.txt")
16401642
return os.path.join(self.resources_path, "test_requirements.txt")
16411643

16421644
@property

0 commit comments

Comments
 (0)