SNOW-2747170: Fix temporary object cleanup using incorrect identifiers (#4000)

Author: sfc-gh-joshi

CHANGELOG.md

@@ -49,6 +49,10 @@
       - `square`
       - `width_bucket`
 
+#### Bug Fixes
+
+- Fixed a bug where automatically-generated temporary objects were not properly cleaned up.
+
 #### Improvements
 
 - Enhanced `DataFrame.sort()` to support `ORDER BY ALL` when no columns are specified.

src/snowflake/snowpark/_internal/compiler/plan_compiler.py

@@ -216,10 +216,10 @@ def replace_temp_obj_placeholders(
                         placeholder_name,
                         temp_obj_type,
                     ) = query.temp_obj_name_placeholder
-                    placeholders[placeholder_name] = random_name_for_temp_object(
-                        temp_obj_type
-                    )
-
+                    if placeholder_name not in placeholders:
+                        placeholders[placeholder_name] = random_name_for_temp_object(
+                            temp_obj_type
+                        )
                 copied_query = copy.copy(query)
                 for placeholder_name, target_temp_name in placeholders.items():
                     # Copy the original query and replace all the placeholder names with the

tests/integ/test_multithreading.py

@@ -848,6 +848,7 @@ def process_data(df_, thread_id):
                 len(unique_create_table_queries) == expected_num_queries
             ), queries_sent
             assert len(unique_drop_table_queries) == expected_num_queries, queries_sent
+            assert unique_create_table_queries == unique_drop_table_queries
 
         finally:
             analyzer.ARRAY_BIND_THRESHOLD = original_value
@@ -913,6 +914,7 @@ def process_data(df_, thread_id):
 
     assert len(unique_create_file_format_queries) == 10
     assert len(unique_drop_file_format_queries) == 10
+    assert unique_create_file_format_queries == unique_drop_file_format_queries
 
 
 @pytest.mark.xfail(