Skip to content

Commit e8e9c87

Browse files
authored
SNOW-1854327: fix test to exclude deleted nodes (#2769)
1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR. Fixes SNOW-1854327 2. Fill out the following pre-review checklist: - [ ] I am adding a new automated test(s) to verify correctness of my new code - [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing - [ ] I am adding new logging messages - [ ] I am adding a new telemetry message - [ ] I am adding new credentials - [ ] I am adding a new dependency - [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes. - [ ] I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: [Thread-safe Developer Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development) 3. Please describe how your code solves the related issue. We have a new commit in snowflakedb (snowflakedb/snowflake#230405) where we stop showing deleted nodes. This test relies on old behavior where we do show deleted nodes. The fix is to update the test to not expect deleted nodes.
1 parent 342c393 commit e8e9c87

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#### Improvements
2727
- Improve performance of `DataFrame.map`, `Series.apply` and `Series.map` methods by mapping numpy functions to snowpark functions if possible.
28+
- Updated integration testing for `session.lineage.trace` to exclude deleted objects
2829

2930
## 1.26.0 (2024-12-05)
3031

tests/integ/test_lineage.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -200,19 +200,10 @@ def test_lineage_trace(session):
200200
df = remove_created_on_field(df.to_pandas())
201201

202202
expected_data = {
203-
"SOURCE_OBJECT": [
204-
{"domain": "VIEW", "name": f"{db}.{schema}.V2", "status": "ACTIVE"},
205-
{"domain": "VIEW", "name": f"{db}.{schema}.V3", "status": "DELETED"},
206-
],
207-
"TARGET_OBJECT": [
208-
{"domain": "VIEW", "name": f"{db}.{schema}.V3", "status": "DELETED"},
209-
{"domain": "VIEW", "name": f"{db}.{schema}.V4", "status": "ACTIVE"},
210-
],
211-
"DIRECTION": [
212-
"Downstream",
213-
"Downstream",
214-
],
215-
"DISTANCE": [1, 2],
203+
"SOURCE_OBJECT": [],
204+
"TARGET_OBJECT": [],
205+
"DIRECTION": [],
206+
"DISTANCE": [],
216207
}
217208

218209
expected_df = pd.DataFrame(expected_data)

0 commit comments

Comments
 (0)