Skip to content

Commit f268cb5

Browse files
committed
test fixups
1 parent 9c275df commit f268cb5

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

.github/workflows/precommit.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,6 @@ jobs:
181181
# For example, see https://github.com/snowflakedb/snowpark-python/pull/681
182182
shell: bash
183183
# do not run other tests for macos
184-
- if: ${{ matrix.os == 'macos-latest' && matrix.python-version == '3.12'}}
185-
name: Run doctests
186-
run: python -m tox -e "py${PYTHON_VERSION}-notudfdoctest-ci"
187-
env:
188-
PYTHON_VERSION: ${{ matrix.python-version }}
189-
cloud_provider: ${{ matrix.cloud-provider }}
190-
PYTEST_ADDOPTS: --color=yes --tb=short
191-
TOX_PARALLEL_NO_SPINNER: 1
192-
SNOWFLAKE_IS_PYTHON_RUNTIME_TEST: 1
193-
shell: bash
194184
- if: ${{ matrix.os != 'macos-latest' && matrix.python-version != '3.12' }}
195185
name: Run tests (excluding doctests)
196186
run: python -m tox -e "py${PYTHON_VERSION/\./}-notdoctest-ci"
@@ -200,7 +190,7 @@ jobs:
200190
PYTEST_ADDOPTS: --color=yes --tb=short
201191
TOX_PARALLEL_NO_SPINNER: 1
202192
shell: bash
203-
- if: ${{ matrix.os != 'macos-latest' && matrix.python-version == '3.12' }}
193+
- if: ${{ matrix.python-version == '3.12' }}
204194
name: Run tests (excluding doctests and udf tests)
205195
run: python -m tox -e "py${PYTHON_VERSION/\./}-notudfdoctest-ci"
206196
env:

tests/integ/test_dataframe.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4272,9 +4272,14 @@ def test_create_empty_dataframe(session):
42724272
def test_dataframe_to_local_iterator_with_to_pandas_isolation(
42734273
session, local_testing_mode
42744274
):
4275-
df = session.create_dataframe(
4276-
[["xyz", int("1" * 19)] for _ in range(200000)], schema=["a1", "b1"]
4277-
)
4275+
if local_testing_mode:
4276+
df = session.create_dataframe(
4277+
[["xyz", int("1" * 19)] for _ in range(200000)], schema=["a1", "b1"]
4278+
)
4279+
else:
4280+
df = session.sql(
4281+
"select 'xyz' as A1, 1111111111111111111 as B1 from table(generator(rowCount => 200000))"
4282+
)
42784283
trigger_df = session.create_dataframe(
42794284
[[1.0]], schema=StructType([StructField("A", DecimalType())])
42804285
)

tests/integ/test_packaging.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -599,6 +599,7 @@ def check_if_package_works() -> str:
599599
)
600600

601601

602+
@pytest.mark.udf
602603
@pytest.mark.skipif(
603604
IS_IN_STORED_PROC,
604605
reason="Subprocess calls are not allowed within stored procedures.",

0 commit comments

Comments
 (0)