Skip to content

Conversation

@sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Unskip doctest for table_function.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested review from a team as code owners December 17, 2025 00:26
@sfc-gh-helmeleegy sfc-gh-helmeleegy marked this pull request as draft December 17, 2025 00:26
@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 17, 2025
@sfc-gh-helmeleegy
Copy link
Contributor Author

sfc-gh-helmeleegy commented Dec 17, 2025

Daily precommit run: https://github.com/snowflakedb/snowpark-python/actions/runs/20287879090
While the run failed overall, it was for other reasons. The doctest for table_function (which is the subject of this PR) passed for all tests in the run.

@sfc-gh-helmeleegy sfc-gh-helmeleegy marked this pull request as ready for review December 17, 2025 03:59
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 7d70182 into main Dec 20, 2025
25 of 28 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-no-snow-table_function_doctest_unskip branch December 20, 2025 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants