Skip to content

SNOW-3027686: Fix spark string format for interval year-month #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sfc-gh-nkumar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-3027686: Fix spark string format for interval year-month #4062

sfc-gh-nkumar wants to merge 1 commit into from

Conversation

@sfc-gh-nkumar
Copy link
Contributor

@sfc-gh-nkumar sfc-gh-nkumar commented Jan 28, 2026 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3027686

Process year-month Intervals of format '+/-ddd' correctly.

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-nkumar sfc-gh-nkumar requested review from a team as code owners January 28, 2026 02:16
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-3027686-interval-format branch from b17f2fd to c317f76 Compare January 28, 2026 02:28
@sfc-gh-nkumar sfc-gh-nkumar added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 28, 2026
@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-3027686-interval-format branch from c317f76 to 2529121 Compare January 28, 2026 02:29
sfc-gh-fhe
sfc-gh-fhe reviewed Jan 28, 2026
View reviewed changes
@sfc-gh-mayliu
Copy link
Collaborator

sfc-gh-mayliu commented Jan 28, 2026

Thanks for fixing the interval string format, here's the SnowparkPythonSnowflakePythonClientRegressRunner Jenkins job triggered from your branch: https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/SnowparkPythonSnowflakePythonClientRegressRunner/197893/consoleFull

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-3027686-interval-format branch 3 times, most recently from c7edbed to c4da91b Compare January 28, 2026 19:58
sfc-gh-fhe
sfc-gh-fhe approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@sfc-gh-fhe sfc-gh-fhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

sfc-gh-mayliu
sfc-gh-mayliu reviewed Jan 28, 2026
View reviewed changes
tests/integ/scala/test_dataframe_suite.py
assert test_result[0][0] == "+3-00"
assert test_result[0][1] == "+1-06"
assert test_result[0][2] == "+1-03"
assert test_result[0][0] == "+3" # interval year
Copy link
Collaborator

@sfc-gh-mayliu sfc-gh-mayliu Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a discrepancy for test results in different environment. While tests passed in Jenkins, GH actions failed with AssertionError: assert '+3-00' == '+3'

Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins uses the main branch of the Python connector rather than a release version. @sfc-gh-nkumar mentioned that this change may be responsible for this format difference.

Copy link
Collaborator

@sfc-gh-mayliu sfc-gh-mayliu Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion offline:

  1. Python Connector's INTERVAL string format fix is not released yet, which would be released towards the end of month
  2. Snowpark Python's GH merge gate runs on a released version of Python Connector; expectedly, merge gate fails until next Connector release
  3. Upon Connector's next release, this PR would consider backward compatibility with Python Connector's dependency floor

@sfc-gh-nkumar sfc-gh-nkumar force-pushed the nkumar-SNOW-3027686-interval-format branch from c4da91b to 7144d33 Compare January 28, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mayliu sfc-gh-mayliu sfc-gh-mayliu approved these changes

@sfc-gh-fhe sfc-gh-fhe sfc-gh-fhe approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-bkogan sfc-gh-bkogan Awaiting requested review from sfc-gh-bkogan sfc-gh-bkogan is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-nkumar @sfc-gh-mayliu @sfc-gh-fhe @sfc-gh-joshi