Skip to content

SNOW-3244422: Fix dense_rank() failure with ValueError on NULL partition values#4135

Merged
sfc-gh-helmeleegy merged 3 commits intomainfrom
helmeleegy-SNOW-3244422
Mar 25, 2026
Merged

SNOW-3244422: Fix dense_rank() failure with ValueError on NULL partition values#4135
sfc-gh-helmeleegy merged 3 commits intomainfrom
helmeleegy-SNOW-3244422

Conversation

@sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3244422

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Fix dense_rank() failure with ValueError on NULL partition values.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested review from a team as code owners March 24, 2026 23:52
@github-actions github-actions bot added the local testing Local Testing issues/PRs label Mar 24, 2026
@sfc-gh-helmeleegy sfc-gh-helmeleegy force-pushed the helmeleegy-SNOW-3244422 branch from d4f1d5f to f8e978a Compare March 25, 2026 00:12
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fix for local testing only? The only non-test file changed appears to be under the mock folder, which shouldn't affect query generation.

@sfc-gh-helmeleegy
Copy link
Contributor Author

Is this fix for local testing only? The only non-test file changed appears to be under the mock folder, which shouldn't affect query generation.

I think src/snowflake/snowpark/mock/_plan.py is a production file. It's part of the local testing framework's runtime, where it evaluates query plans using pandas when users run with local_testing=True.

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit bc7b1e7 into main Mar 25, 2026
29 of 30 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-3244422 branch March 25, 2026 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

local testing Local Testing issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants